Fix test task to fail on test failures (#17377)

* Fix test task to fail on test failures

* remove unused done

* Try fix result upload

Author: Charles-Gagnon

build/build.yml

@@ -28,6 +28,12 @@ steps:
   - bash: "gulp test:cover"
     displayName: "gulp test:cover"
 
+  - task: PublishTestResults@2
+    inputs:
+      testResultsFormat: 'JUnit'
+      testResultsFiles: 'test-reports/test-results-ext.xml'
+    condition: succeededOrFailed()
+
   - bash: "gulp cover:combine-json"
     displayName: "gulp cover:combine-json"
 
@@ -104,22 +110,6 @@ steps:
     inputs:
       targets: "ext:install-service"
 
-  - task: gulp@0
-    displayName: "gulp cover:jenkins"
-    inputs:
-      targets: "cover:jenkins"
-      publishJUnitResults: true
-      testResultsFiles: "$(Build.SourcesDirectory)/test-reports/*.xml"
-    enabled: false
-    continueOnError: true
-
-  - task: PublishCodeCoverageResults@1
-    displayName: "Publish code coverage from $(Build.SourcesDirectory)/coverage/cobertura-coverage.xml"
-    inputs:
-      codeCoverageTool: Cobertura
-      summaryFileLocation: "$(Build.SourcesDirectory)/coverage/cobertura-coverage.xml"
-    enabled: false
-
   - task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
     displayName: "Component Detection"
     inputs:

gulpfile.js

@@ -237,30 +237,22 @@ gulp.task('ext:localization', gulp.series('ext:localization:generate-eng-package
 
 gulp.task('ext:build', gulp.series('ext:localization', 'ext:copy', 'ext:clean-library-ts-files', 'ext:compile', 'ext:compile-view')); // removed lint before copy
 
-gulp.task('ext:test', async (done) => {
+gulp.task('ext:test', async () => {
 	let workspace = process.env['WORKSPACE'];
 	if (!workspace) {
 		workspace = process.cwd();
 	}
-	process.env.JUNIT_REPORT_PATH = workspace + '/test-reports/ext_xunit.xml';
+	process.env.JUNIT_REPORT_PATH = workspace + '/test-reports/test-results-ext.xml';
 	var args = ['--verbose', '--disable-gpu', '--disable-telemetry', '--disable-updates', '-n'];
 	let vscodeVersion = packageJson.engines.vscode.slice(1);
 	let extensionTestsPath = `${workspace}/out/test`;
 	let vscodePath = await vscodeTest.downloadAndUnzipVSCode(vscodeVersion);
-	try {
-		await vscodeTest.runTests({
-			vscodeExecutablePath: vscodePath,
-			extensionDevelopmentPath: workspace,
-			extensionTestsPath: extensionTestsPath,
-			launchArgs: args
-		});
-	} catch (error) {
-		console.log(`stdout: ${process.stdout}`);
-		console.log(`stderr: ${process.stderr}`);
-		console.error(`exec error: ${error}`);
-	}
-	done();
-	process.exit(0);
+	await vscodeTest.runTests({
+		vscodeExecutablePath: vscodePath,
+		extensionDevelopmentPath: workspace,
+		extensionTestsPath: extensionTestsPath,
+		launchArgs: args
+	});
 });
 
 gulp.task('test', gulp.series('ext:test'));