Improve connection string and empty workspace folder case (#17229)

* improve connection string and corner case

* comments

Author: VasuBhog

src/azureFunction/azureFunctionUtils.ts

@@ -149,6 +149,9 @@ export async function getAzureFunctionProject(): Promise<string | undefined> {
 export async function getAzureFunctionProjectFiles(): Promise<string[] | undefined> {
 	let projFiles: string[] = [];
 	const hostFiles = await getHostFiles();
+	if (!hostFiles) {
+		return undefined;
+	}
 	for (let host of hostFiles) {
 		let projectFile = await vscode.workspace.findFiles('*.csproj', path.dirname(host));
 		projectFile.filter(file => path.dirname(file.fsPath) === path.dirname(host) ? projFiles.push(file?.fsPath) : projFiles);

src/controllers/mainController.ts

@@ -32,7 +32,6 @@ import { QueryHistoryProvider } from '../queryHistory/queryHistoryProvider';
 import { QueryHistoryNode } from '../queryHistory/queryHistoryNode';
 import { DacFxService } from '../services/dacFxService';
 import { IConnectionInfo } from 'vscode-mssql';
-import { getConnectionString } from '../utils/connectionStringUtil';
 import { SchemaCompareService } from '../services/schemaCompareService';
 import { SqlTasksService } from '../services/sqlTasksService';
 import { AzureFunctionsService } from '../services/azureFunctionsService';
@@ -443,14 +442,9 @@ export default class MainController implements vscode.Disposable {
 
 		// Generate Azure Function command
 		this._context.subscriptions.push(vscode.commands.registerCommand(Constants.cmdCreateAzureFunction, async (node: TreeNodeInfo) => {
-			const database = ObjectExplorerUtils.getDatabaseName(node);
-			const connStr = getConnectionString(
-				node.connectionInfo.server,
-				node.connectionInfo.authenticationType,
-				database,
-				node.connectionInfo.user,
-				node.connectionInfo.password);
-			await this.azureFunctionsService.createAzureFunction(connStr, node.metadata.schema, node.metadata.name);
+			const connectionUri = this._connectionMgr.getUriForConnection(node.connectionInfo);
+			const connectionString = await this._connectionMgr.getConnectionString(connectionUri);
+			await this.azureFunctionsService.createAzureFunction(connectionString, node.metadata.schema, node.metadata.name);
 		}));
 	}