added displayName for MRU list to avoid setting profileName unexpectedly

Author: Benjin

src/connectionconfig/connectionDialogWebViewController.ts

@@ -139,8 +139,8 @@ export class ConnectionDialogWebViewController extends ReactWebViewPanelControll
 		}
 
 		const dialogConnection = connection as IConnectionDialogProfile;
-		// Set the profile name
-		dialogConnection.profileName = dialogConnection.profileName ?? getConnectionDisplayName(connection);
+		// Set the display name
+		dialogConnection.displayName = dialogConnection.profileName ? dialogConnection.profileName : getConnectionDisplayName(connection);
 		return dialogConnection;
 	}
 

src/reactviews/pages/ConnectionDialog/mruConnectionsContainer.tsx

@@ -54,7 +54,7 @@ export const MruConnectionsContainer = () => {
 							connectionDialogContext.loadConnection(connection);
 						}}>
 							<TreeItemLayout iconBefore={<ServerRegular />}>
-								{connection.profileName}
+								{connection.displayName}
 							</TreeItemLayout>
 						</TreeItem>;
 					})

src/sharedInterfaces/connectionDialog.ts

@@ -66,10 +66,10 @@ export interface IConnectionDialogProfile extends vscodeMssql.IConnectionInfo {
 	savePassword?: boolean;
 	emptyPasswordInput?: boolean;
 	azureAuthType?: vscodeMssql.AzureAuthType;
+    /** display name for the MRU pane; should be set to the profileName if available, otherwise generated from connection details */
+    displayName?: string;
 }
 
-
-
 export interface ConnectionDialogContextProps extends FormContextProps<ConnectionDialogWebviewState, IConnectionDialogProfile> {
 	theme: Theme;
 	loadConnection: (connection: IConnectionDialogProfile) => void;