Skip to content

Commit df11eb4

Browse files
authored
Adding settings for enable experimental features. (#18008)
1 parent b32ac94 commit df11eb4

File tree

5 files changed

+17
-3
lines changed

5 files changed

+17
-3
lines changed

localization/xliff/enu/localizedPackage.json.enu.xlf

+3
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,9 @@
440440
</trans-unit id="mssql.openExecutionPlanFile">
441441
<source xml:lang="en">Open Execution Plan File</source>
442442
</trans-unit>
443+
<trans-unit id="mssql.enableExperimentalFeatures.description">
444+
<source xml:lang="en">Enables experimental features in the MSSQL extension. The features are not production-ready and may have bugs or issues. Restart Visual Studio Code after changing this setting.</source>
445+
</trans-unit>
443446
</body>
444447
</file>
445448
</xliff>

package.json

+6
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,12 @@
739739
"type": "object",
740740
"title": "%mssql.Configuration%",
741741
"properties": {
742+
"mssql.enableExperimentalFeatures": {
743+
"type": "boolean",
744+
"default": false,
745+
"description": "%mssql.enableExperimentalFeatures.description%",
746+
"scope": "application"
747+
},
742748
"mssql.azureActiveDirectory": {
743749
"type": "string",
744750
"default": "AuthCodeGrant",

package.nls.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,6 @@
143143
"mssql.objectExplorer.expandTimeout":"The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.",
144144
"mssql.newTable":"New Table",
145145
"mssql.editTable":"Edit Table",
146-
"mssql.editConnection":"Edit Connection"
146+
"mssql.editConnection":"Edit Connection",
147+
"mssql.enableExperimentalFeatures.description":"Enables experimental features in the MSSQL extension. The features are not production-ready and may have bugs or issues. Restart Visual Studio Code after changing this setting."
147148
}

src/constants/constants.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export const configPersistQueryResultTabs = 'persistQueryResultTabs';
158158
export const configQueryHistoryLimit = 'queryHistoryLimit';
159159
export const configEnableQueryHistoryCapture = 'enableQueryHistoryCapture';
160160
export const configEnableQueryHistoryFeature = 'enableQueryHistoryFeature';
161-
export const configEnableExperimentalFeatures = 'enableExperimentalFeatures';
161+
export const configEnableExperimentalFeatures = 'mssql.enableExperimentalFeatures';
162162

163163
// ToolsService Constants
164164
export const serviceInstallingTo = 'Installing SQL tools service to';

src/controllers/mainController.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export default class MainController implements vscode.Disposable {
9292
}
9393
this._vscodeWrapper = vscodeWrapper || new VscodeWrapper();
9494
this._untitledSqlDocumentService = new UntitledSqlDocumentService(this._vscodeWrapper);
95-
this.configuration = vscode.workspace.getConfiguration(Constants.extensionName);
95+
this.configuration = vscode.workspace.getConfiguration();
9696
}
9797

9898
/**
@@ -1385,6 +1385,10 @@ export default class MainController implements vscode.Disposable {
13851385
if (e.affectsConfiguration(Constants.enableConnectionPooling)) {
13861386
await this.displayReloadMessage(LocalizedConstants.reloadPromptGeneric);
13871387
}
1388+
1389+
if(e.affectsConfiguration(Constants.configEnableExperimentalFeatures)) {
1390+
await this.displayReloadMessage(LocalizedConstants.reloadPromptGeneric);
1391+
}
13881392
}
13891393
}
13901394

0 commit comments

Comments
 (0)