Move rulesDirectory from JSON to tasks (#1225)

This is so TSA scans can use the same tslint JSON file (they download the rule additions to a different directory)

Author: Charles-Gagnon

gulpfile.js

@@ -25,6 +25,7 @@ require('./tasks/htmltasks')
 require('./tasks/packagetasks')
 
 gulp.task('ext:lint', () => {
+    // !! If updating this make sure to check if you need to update the TSA Scan task in ADO !!
     var program = tslint.Linter.createProgram('tsconfig.json');
     return gulp.src([
         config.paths.project.root + '/src/**/*.ts',
@@ -33,7 +34,8 @@ gulp.task('ext:lint', () => {
     ])
     .pipe((gulpTsLint({
         program,
-        formatter: "verbose"
+        formatter: "verbose",
+        rulesDirectory: "node_modules/tslint-microsoft-contrib"
     })))
     .pipe(gulpTsLint.report());
 });

tasks/htmltasks.js

@@ -18,16 +18,18 @@ var tslint = require('tslint');
 var min = (argv.min === undefined) ? false : true;
 
 gulp.task('html:lint', () => {
+    // !! If updating this make sure to check if you need to update the TSA Scan task in ADO !!
     var program = tslint.Linter.createProgram(config.paths.html.root + '/tsconfig.json');
     return gulp.src([
         config.paths.html.root + '/src/**/*.ts',
         config.paths.html.root + '/test/**/*.ts'
     ])
     .pipe((gulpTsLint({
         program,
-        formatter: "verbose"
+        formatter: "verbose",
+        rulesDirectory: "node_modules/tslint-microsoft-contrib"
     })))
-    .pipe(gulpTsLint.report());
+    .pipe(gulpTsLint.report())
 });
 
 // Compile TypeScript to JS

tslint.mssdl.required.json

@@ -1,5 +1,4 @@
 {
-  "rulesDirectory": "node_modules/tslint-microsoft-contrib",
   "rules": {
     "no-banned-terms": true,
     "no-delete-expression": true,