Error when reloading the workbench with custom tree views open (#4772)

Fixes #4771

Author: alexr00

src/github/folderRepositoryManager.ts

@@ -1253,7 +1253,7 @@ export class FolderRepositoryManager implements vscode.Disposable {
 			query,
 		);
 		if (includeIssuesWithoutMilestone) {
-			const additionalIssues: ItemsResponseResult<IssueModel> = await this.fetchPagedData<IssueModel>(
+			const additionalIssues: ItemsResponseResult<Issue> = await this.fetchPagedData<Issue>(
 				options,
 				'issuesKey',
 				PagedDataType.IssuesWithoutMilestone,
@@ -1266,7 +1266,10 @@ export class FolderRepositoryManager implements vscode.Disposable {
 					id: '',
 					title: NO_MILESTONE,
 				},
-				issues: additionalIssues.items,
+				issues: await Promise.all(additionalIssues.items.map(async (issue) => {
+					const githubRepository = await this.getRepoForIssue(issue);
+					return new IssueModel(githubRepository, githubRepository.remote, issue);
+				})),
 			});
 		}
 		return milestones;

src/github/repositoriesManager.ts

@@ -28,8 +28,6 @@ export interface PullRequestDefaults {
 	base: string;
 }
 
-export const NO_MILESTONE: string = 'No Milestone';
-
 export class RepositoriesManager implements vscode.Disposable {
 	static ID = 'RepositoriesManager';
 

src/github/utils.ts

@@ -661,9 +661,9 @@ export function parseGraphQLIssue(issue: GraphQL.PullRequest, githubRepository:
 		assignees: issue.assignees?.nodes.map(assignee => parseAuthor(assignee, githubRepository)),
 		user: parseAuthor(issue.author, githubRepository),
 		labels: issue.labels.nodes,
-		repositoryName: issue.repository?.name,
-		repositoryOwner: issue.repository?.owner.login,
-		repositoryUrl: issue.repository?.url,
+		repositoryName: issue.repository?.name ?? githubRepository.remote.repositoryName,
+		repositoryOwner: issue.repository?.owner.login ?? githubRepository.remote.owner,
+		repositoryUrl: issue.repository?.url ?? githubRepository.remote.url,
 	};
 }