Skip to content

Cannot View Pull Request Description after a few days. #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreens opened this issue Apr 27, 2023 · 4 comments
Closed

Cannot View Pull Request Description after a few days. #4783

dreens opened this issue Apr 27, 2023 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@dreens
Copy link

dreens commented Apr 27, 2023

Using GitHub Pull Request and Issues Extension v0.63.2023042009 (or v0.62)
Using Github Enterprise 3.2.20.
I'm having an issue where I can't load the description page of open pull requests after a day or two. Clicking on "Description" beneath the expanded view of the pull request has no effect, nor does clicking on the smaller "Open Pull Request Description to the Side" button.
image

When I look at the output of GitHub Pull Request in vscode, I find an error that appears:
[error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Field 'subjectType' doesn't exist on type 'PullRequestReviewThread'
image

This seems similar to an older closed issue, #2772.

Rebooting vscode, or the computer, doesn't address the issue.
It never happens when I first view a pull request, or newly create one myself.
It always happens eventually, after a few days.
I've had it happen with a dozen or so pull requests so far over last two months.

@dreens
Copy link
Author

dreens commented Apr 27, 2023

I have discovered an important piece related to this issue.
Specifying a default web browser and rebooting vscode has resolved the issue, at least temporarily.
Does github pull request depend upon there being a default web browser specified on the machine?
Would it be possible to specify a browser to use with a local setting instead of relying on the global windows setting?
My windows 10 image is slightly faulty and forgets the default web-browser after every reboot.

@alexr00 alexr00 self-assigned this May 2, 2023
@alexr00
Copy link
Member

alexr00 commented May 2, 2023

@dreens do your git remotes use ssh? If so, not being able to open the description could be #4768

[error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Field 'subjectType' doesn't exist on type 'PullRequestReviewThread'

I will likely need to make a fix for this.

@alexr00 alexr00 added the info-needed Issue requires more information from poster label May 2, 2023
@dreens
Copy link
Author

dreens commented May 2, 2023

Hi @alexr00 thanks for your reply. No, I am not using SSH. I can confirm that specifying a default web browser in my windows 10 settings resolves this issue.

Perhaps I should close the issue? It would be nice, though, if some appropriate error message were registered relating to the lack of a default web browser, rather than the nearly silent failure at present.

@alexr00
Copy link
Member

alexr00 commented May 3, 2023

It would be nice, though, if some appropriate error message were registered relating to the lack of a default web browser, rather than the nearly silent failure at present.

I don't see why specifying a default web browser should make a difference.

The PR description is displayed using a webview. Next time you see this issue with the PR description can you open another webview (such as the release notes by running the command to show the release notes) and see if that webview shows properly?

@alexr00 alexr00 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants