Address pr comments

Author: edvilme

package-lock.json

@@ -738,7 +738,7 @@
         "@vscode/test-cli": "^0.0.10",
         "dotenv": "^16.4.5",
         "fs-extra": "^11.2.0",
-        "semver": "^7.7.4",
+        "semver": "^7.8.0",
         "stack-trace": "0.0.10",
         "vscode-jsonrpc": "^9.0.0-next.5",
         "which": "^4.0.0"

package.json

@@ -700,7 +700,7 @@ export interface PackageManager {
      * @returns A promise that resolves to an array of version strings (newest first),
      *          or `undefined` if this manager does not support version listing.
      */
-    getAvailableVersions?(packageName: string, environment: PythonEnvironment): Promise<string[] | undefined>;
+    getAvailableVersions?(packageName: string, environment: PythonEnvironment): Promise<semver.SemVer[] | undefined>;
 }
 
 /**
@@ -1086,7 +1086,7 @@ export interface PythonPackageVersionApi {
      * @param environment The Python Environment context for the lookup.
      * @returns An array of version strings (newest first), or `undefined` if not supported.
      */
-    getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<string[] | undefined>;
+    getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<semver.SemVer[] | undefined>;
 }
 
 export interface PythonPackageManagerApi

src/api.ts

@@ -337,8 +337,8 @@ export async function handlePackageVersionManagement(context: unknown, em: Envir
 
         if (availableVersions && availableVersions.length > 0) {
             const items = availableVersions.map((v) => ({
-                label: v,
-                description: v === pkg.version ? `$(check) ${l10n.t('Installed')}` : undefined,
+                label: v.version,
+                description: v.version === pkg.version ? `$(check) ${l10n.t('Installed')}` : undefined,
             }));
 
             const selected = await showQuickPick(items, {

src/features/envCommands.ts

@@ -277,7 +277,7 @@ class PythonEnvironmentApiImpl implements PythonEnvironmentApi {
         return manager.getVersion(environment);
     }
 
-    async getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<string[] | undefined> {
+    async getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<semver.SemVer[] | undefined> {
         await waitForEnvManagerId([environment.envId.managerId]);
         const manager = this.envManagers.getPackageManager(environment);
         if (!manager) {

src/features/pythonApi.ts

@@ -384,7 +384,7 @@ export class InternalPackageManager implements PackageManager {
         return this.manager.getVersion ? this.manager.getVersion(environment) : Promise.resolve(undefined);
     }
 
-    getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<string[] | undefined> {
+    getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<semver.SemVer[] | undefined> {
         return this.manager.getAvailableVersions
             ? this.manager.getAvailableVersions(packageName, environment)
             : Promise.resolve(undefined);

src/internal.api.ts

@@ -156,7 +156,7 @@ export class PipPackageManager implements PackageManager, Disposable {
         }
     }
 
-    async getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<string[] | undefined> {
+    async getAvailableVersions(packageName: string, environment: PythonEnvironment): Promise<semver.SemVer[] | undefined> {
         try {
             const python = environment.execInfo?.run?.executable;
             if (!python) {
@@ -215,21 +215,22 @@ export class PipPackageManager implements PackageManager, Disposable {
  *   No matching distribution found for <package>==__invalid__
  * ```
  */
-export function parsePipInstallVersions(output: string): string[] | undefined {
+export function parsePipInstallVersions(output: string): semver.SemVer[] | undefined {
     const match = output.match(/from versions:\s*([^\)]+)\)/);
     if (match && match[1]) {
         return match[1]
             .split(',')
-            .map((v) => v.trim())
-            .filter((v) => v.length > 0);
+            .filter((v) => !!v.trim())
+            .map((v) => semver.coerce(v.trim()) as semver.SemVer)
+            .sort((a, b) => semver.rcompare(a, b));
     }
 }
 
 /**
  * Parses JSON output from `pip index versions <package> --json`.
  * Expected format: { "name": "...", "versions": ["1.2.3", "1.2.2", ...] }
  */
-export function parsePipIndexVersionsJson(output: string): string[] | undefined {
+export function parsePipIndexVersionsJson(output: string): semver.SemVer[] | undefined {
     // Only capture output between braces
     const match = output.match(/{[\s\S]*}/);
     if (!match) {
@@ -238,7 +239,10 @@ export function parsePipIndexVersionsJson(output: string): string[] | undefined
     try {
         const parsed = JSON.parse(match[0]);
         if (parsed && Array.isArray(parsed.versions) && parsed.versions.length > 0) {
-            return parsed.versions;
+            return (parsed.versions as string[])
+                .filter((v) => !!v.trim())
+                .map((v) => semver.coerce(v) as semver.SemVer)
+                .sort((a, b) => semver.rcompare(a, b));
         }
         return undefined;
     } catch {

src/managers/builtin/pipManager.ts

@@ -40,7 +40,10 @@ export class CondaPackageManager implements PackageManager, Disposable {
 
     private packages: Map<string, Package[]> = new Map();
 
-    constructor(public readonly api: PythonEnvironmentApi, public readonly log: LogOutputChannel) {
+    constructor(
+        public readonly api: PythonEnvironmentApi,
+        public readonly log: LogOutputChannel,
+    ) {
         this.name = 'conda';
         this.displayName = 'Conda';
         this.description = CondaStrings.condaPackageMgr;
@@ -128,22 +131,21 @@ export class CondaPackageManager implements PackageManager, Disposable {
             const output = await runCondaExecutable(['--version'], this.log);
             // "conda X.Y.Z"
             const match = output.match(/conda\s+(\d+\.\d+(?:\.\d+)*)/i);
-            return match ? semver.coerce(match[1]) ?? undefined : undefined;
+            return match ? (semver.coerce(match[1]) ?? undefined) : undefined;
         } catch {
             return undefined;
         }
     }
 
-    async getAvailableVersions(packageName: string, _environment: PythonEnvironment): Promise<string[] | undefined> {
+    async getAvailableVersions(packageName: string, _environment: PythonEnvironment): Promise<semver.SemVer[] | undefined> {
         try {
             const output = await runCondaExecutable(['search', packageName, '--json'], this.log);
             const parsed = JSON.parse(output);
             if (parsed && typeof parsed === 'object' && Array.isArray(parsed[packageName])) {
-                const versions: string[] = parsed[packageName]
-                    .map((entry: { version?: string }) => entry.version)
-                    .filter((v: unknown): v is string => typeof v === 'string');
-                // Deduplicate and return newest first
-                return [...new Set(versions)].reverse();
+                return parsed[packageName]
+                    .filter((entry: { version?: string }) => !!entry.version?.trim())
+                    .map((entry: { version?: string }) => semver.coerce(entry.version) as semver.SemVer)
+                    .sort((a: semver.SemVer, b: semver.SemVer) => semver.rcompare(a, b));
             }
             return undefined;
         } catch {

src/managers/conda/condaPackageManager.ts

@@ -164,7 +164,7 @@ export class PoetryPackageManager implements PackageManager, Disposable {
         return versionStr ? semver.coerce(versionStr) ?? undefined : undefined;
     }
 
-    async getAvailableVersions(_packageName: string, _environment: PythonEnvironment): Promise<string[] | undefined> {
+    async getAvailableVersions(_packageName: string, _environment: PythonEnvironment): Promise<semver.SemVer[] | undefined> {
         // Poetry doesn't have a native "list available versions" command.
         // Poetry 2.x supports `poetry search` but it was disabled on PyPI.
         // Return undefined to indicate this manager doesn't support version listing.

src/managers/poetry/poetryPackageManager.ts

@@ -1,18 +1,19 @@
 import assert from 'assert';
+import * as semver from 'semver';
 import { parsePipIndexVersionsJson } from '../../../managers/builtin/pipManager';
 
 suite('Pip Version Parsing', () => {
     suite('parsePipIndexVersionsJson', () => {
         test('parses valid JSON with versions array', () => {
             const output = JSON.stringify({ name: 'requests', versions: ['2.31.0', '2.30.0', '2.29.0'] });
             const versions = parsePipIndexVersionsJson(output);
-            assert.deepStrictEqual(versions, ['2.31.0', '2.30.0', '2.29.0']);
+            assert.deepStrictEqual(versions, ['2.31.0', '2.30.0', '2.29.0'].map((v) => semver.coerce(v)));
         });
 
         test('parses output with a single version', () => {
             const output = JSON.stringify({ name: 'my-package', versions: ['1.0.0'] });
             const versions = parsePipIndexVersionsJson(output);
-            assert.deepStrictEqual(versions, ['1.0.0']);
+            assert.deepStrictEqual(versions, [semver.coerce('1.0.0')]);
         });
 
         test('returns undefined for empty versions array', () => {