Fix: Validate existence of pipenv, poetry, and pyenv paths before usage

Author: karthiknadig

src/managers/pipenv/pipenvUtils.ts

@@ -54,22 +54,32 @@ function getPipenvPathFromSettings(): string | undefined {
 
 export async function getPipenv(native?: NativePythonFinder): Promise<string | undefined> {
     if (pipenvPath) {
-        return pipenvPath;
+        if (await fs.exists(untildify(pipenvPath))) {
+            return untildify(pipenvPath);
+        }
+        pipenvPath = undefined;
     }
 
     const state = await getWorkspacePersistentState();
-    pipenvPath = await state.get<string>(PIPENV_PATH_KEY);
-    if (pipenvPath) {
-        traceInfo(`Using pipenv from persistent state: ${pipenvPath}`);
-        return pipenvPath;
+    const storedPath = await state.get<string>(PIPENV_PATH_KEY);
+    if (storedPath) {
+        if (await fs.exists(untildify(storedPath))) {
+            pipenvPath = storedPath;
+            traceInfo(`Using pipenv from persistent state: ${pipenvPath}`);
+            return untildify(pipenvPath);
+        }
+        await state.set(PIPENV_PATH_KEY, undefined);
     }
 
     // try to get from settings
     const settingPath = getPipenvPathFromSettings();
     if (settingPath) {
-        pipenvPath = settingPath;
-        traceInfo(`Using pipenv from settings: ${settingPath}`);
-        return pipenvPath;
+        if (await fs.exists(untildify(settingPath))) {
+            pipenvPath = settingPath;
+            traceInfo(`Using pipenv from settings: ${settingPath}`);
+            return untildify(pipenvPath);
+        }
+        traceInfo(`Pipenv path from settings does not exist: ${settingPath}`);
     }
 
     // Try to find pipenv in PATH

src/managers/poetry/poetryUtils.ts

@@ -106,28 +106,38 @@ export async function setPoetryForWorkspaces(fsPath: string[], envPath: string |
 
 export async function getPoetry(native?: NativePythonFinder): Promise<string | undefined> {
     if (poetryPath) {
-        return poetryPath;
+        if (await fs.exists(untildify(poetryPath))) {
+            return untildify(poetryPath);
+        }
+        poetryPath = undefined;
     }
 
     const state = await getWorkspacePersistentState();
-    poetryPath = await state.get<string>(POETRY_PATH_KEY);
-    if (poetryPath) {
-        traceInfo(`Using poetry from persistent state: ${poetryPath}`);
-        // Also retrieve the virtualenvs path if we haven't already
-        if (!poetryVirtualenvsPath) {
-            getPoetryVirtualenvsPath(untildify(poetryPath)).catch((e) =>
-                traceError(`Error getting Poetry virtualenvs path: ${e}`),
-            );
+    const storedPath = await state.get<string>(POETRY_PATH_KEY);
+    if (storedPath) {
+        if (await fs.exists(untildify(storedPath))) {
+            poetryPath = storedPath;
+            traceInfo(`Using poetry from persistent state: ${poetryPath}`);
+            // Also retrieve the virtualenvs path if we haven't already
+            if (!poetryVirtualenvsPath) {
+                getPoetryVirtualenvsPath(untildify(poetryPath)).catch((e) =>
+                    traceError(`Error getting Poetry virtualenvs path: ${e}`),
+                );
+            }
+            return untildify(poetryPath);
         }
-        return untildify(poetryPath);
+        await state.set(POETRY_PATH_KEY, undefined);
     }
 
     // try to get from settings
     const settingPath = getPoetryPathFromSettings();
     if (settingPath) {
-        poetryPath = settingPath;
-        traceInfo(`Using poetry from settings: ${settingPath}`);
-        return poetryPath;
+        if (await fs.exists(untildify(settingPath))) {
+            poetryPath = settingPath;
+            traceInfo(`Using poetry from settings: ${settingPath}`);
+            return untildify(poetryPath);
+        }
+        traceInfo(`Poetry path from settings does not exist: ${settingPath}`);
     }
 
     // Check in standard PATH locations

src/managers/pyenv/pyenvUtils.ts

@@ -98,14 +98,21 @@ export async function setPyenvForWorkspaces(fsPath: string[], envPath: string |
 
 export async function getPyenv(native?: NativePythonFinder): Promise<string | undefined> {
     if (pyenvPath) {
-        return pyenvPath;
+        if (await fs.exists(untildify(pyenvPath))) {
+            return untildify(pyenvPath);
+        }
+        pyenvPath = undefined;
     }
 
     const state = await getWorkspacePersistentState();
-    pyenvPath = await state.get<string>(PYENV_PATH_KEY);
-    if (pyenvPath) {
-        traceInfo(`Using pyenv from persistent state: ${pyenvPath}`);
-        return untildify(pyenvPath);
+    const storedPath = await state.get<string>(PYENV_PATH_KEY);
+    if (storedPath) {
+        if (await fs.exists(untildify(storedPath))) {
+            pyenvPath = storedPath;
+            traceInfo(`Using pyenv from persistent state: ${pyenvPath}`);
+            return untildify(pyenvPath);
+        }
+        await state.set(PYENV_PATH_KEY, undefined);
     }
 
     const pyenvBin = isWindows() ? 'pyenv.exe' : 'pyenv';