Skip to content

Commit 06185f3

Browse files
authored
Merge pull request #50 from middleware-labs/add-service-pid
Add service pid for without service name
2 parents c207f44 + 2d6956d commit 06185f3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ Distributed under the Apache License. See `LICENSE` for more information.
7575
[license-url]: https://github.com/middleware-labs/agent-apm-python/blob/master/LICENSE
7676
[linkedin-shield]: https://img.shields.io/badge/-LinkedIn-black.svg?style=for-the-badge&logo=linkedin&colorB=555
7777
[linkedin-url]: https://www.linkedin.com/company/middleware-labs
78-
[product-screenshot]: https://private-user-images.githubusercontent.com/176276560/353724065-da5d3b3b-cd41-4dbc-b322-235eb1e7b0de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzE2NzAxNzcsIm5iZiI6MTczMTY2OTg3NywicGF0aCI6Ii8xNzYyNzY1NjAvMzUzNzI0MDY1LWRhNWQzYjNiLWNkNDEtNGRiYy1iMzIyLTIzNWViMWU3YjBkZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTExNVQxMTI0MzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kYjQwYTkzMDY5MGI2YTIyYjUzYjI3NzkwMWMxMzRkNDM0ZTU2OTZhNGQ2NmQ2MTc2YmM1ZmY0ZTNjNWE4NzEyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.t03mymEssn8wA-KNIb7uIzaMQOMgiK_rBWgnepQ0awI
78+
[product-screenshot]: ./images/353724065-da5d3b3b-cd41-4dbc-b322-235eb1e7b0de.png
Loading

middleware/options.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
DEFAULT_COLLECT_PROFILING = False
4444
DEFAULT_AGENT_SERVICE = "localhost"
4545
DEFAULT_EXPORTER_PROTOCOL = "grpc"
46-
DEFAULT_SERVICE_NAME = "unknown_service:python"
46+
DEFAULT_SERVICE_NAME = f"python-service-{os.getpid()}"
4747
DEFAULT_LOG_LEVEL = "INFO"
4848
DEFAULT_PROPAGATORS = "b3"
4949
DEFAULT_SAMPLE_RATE = 1
@@ -68,7 +68,7 @@
6868
"Missing service name. Specify either "
6969
+ "OTEL_SERVICE_NAME/MW_SERVICE_NAME environment variable or service_name in the "
7070
+ "options parameter. If left unset, this will show up in middleware "
71-
+ "as unknown_service:python"
71+
+ "as python-service-pid"
7272
)
7373

7474
log_levels = {
@@ -245,7 +245,7 @@ def __init__(
245245
OTEL_SERVICE_NAME, os.environ.get(MW_SERVICE_NAME, service_name)
246246
)
247247
if not self.service_name:
248-
_logger.warning(MISSING_SERVICE_NAME_ERROR)
248+
_logger.debug(MISSING_SERVICE_NAME_ERROR)
249249
self.service_name = DEFAULT_SERVICE_NAME
250250

251251
self.collect_traces = parse_bool(MW_APM_COLLECT_TRACES, collect_traces)

0 commit comments

Comments
 (0)