?

Author: miho

src/main/java/eu/mihosoft/vvecmath/Vector3d.java

@@ -433,138 +433,11 @@ default Vector3d transformed(Transform transform, double amount) {
     }
 
     /**
-     * Creates a new vector which is orthogonal to this.
-     *
-     * this_i , this_j , this_k => i,j,k € {1,2,3} permutation
-     *
-     * looking for orthogonal vector o to vector this: this_i * o_i + this_j *
-     * o_j + this_k * o_k = 0
-     *
-     * @return a new vector which is orthogonal to this
+     * Returns a new vector which is orthogonal to this vector.
+     * @return a new vector which is orthogonal to this vector
      */
     default Vector3d orthogonal() {
-
-//        if ((this.x == Double.NaN) || (this.y == Double.NaN) || (this.z == Double.NaN)) {
-//            throw new IllegalStateException("NaN is not a valid entry for a vector.");
-//        }
-        double o1 = 0.0;
-        double o2 = 0.0;
-        double o3 = 0.0;
-
-        Random r = new Random();
-
-        int numberOfZeroEntries = 0;
-
-        if (this.x() == 0) {
-            numberOfZeroEntries++;
-            o1 = r.nextDouble();
-        }
-
-        if (this.y() == 0) {
-            numberOfZeroEntries++;
-            o2 = r.nextDouble();
-        }
-
-        if (this.z() == 0) {
-            numberOfZeroEntries++;
-            o3 = r.nextDouble();
-        }
-
-        switch (numberOfZeroEntries) {
-
-            case 0:
-                // all this_i != 0
-                //
-                //we do not want o3 to be zero
-                while (o3 == 0) {
-                    o3 = r.nextDouble();
-                }
-
-                //we do not want o2 to be zero
-                while (o2 == 0) {
-                    o2 = r.nextDouble();
-                }
-                // calculate or choose randomly ??
-//                o2 = -this.z * o3 / this.y;
-
-                o1 = (-this.y() * o2 - this.z() * o3) / this.x();
-
-                break;
-
-            case 1:
-                // this_i = 0 , i € {1,2,3}
-                // this_j != 0 != this_k , j,k € {1,2,3}\{i}
-                // 
-                // choose one none zero randomly and calculate the other one
-
-                if (this.x() == 0) {
-                    //we do not want o3 to be zero
-                    while (o3 == 0) {
-                        o3 = r.nextDouble();
-                    }
-
-                    o2 = -this.z() * o3 / this.y();
-
-                } else if (this.y() == 0) {
-
-                    //we do not want o3 to be zero
-                    while (o3 == 0) {
-                        o3 = r.nextDouble();
-                    }
-
-                    o1 = -this.z() * o3 / this.x();
-
-                } else if (this.z() == 0) {
-
-                    //we do not want o1 to be zero
-                    while (o1 == 0) {
-                        o1 = r.nextDouble();
-                    }
-
-                    o2 = -this.z() * o1 / this.y();
-                }
-
-                break;
-
-            case 2:
-                // if two parts of this are 0 we can achieve orthogonality
-                // via setting the corressponding part of the orthogonal vector
-                // to zero this is ALREADY DONE in the init (o_i = 0.0)
-                // NO CODE NEEDED
-//                if (this.x == 0) {
-//                    o1 = 0;
-//                } else if (this.y == 0) {
-//                    o2 = 0;
-//                } else if (this.z == 0) {
-//                    o3 = 0;
-//                }
-                break;
-
-            case 3:
-                System.err.println("This vector is equal to (0,0,0). ");
-
-            default:
-                System.err.println("The orthogonal one is set randomly.");
-
-                o1 = r.nextDouble();
-                o2 = r.nextDouble();
-                o3 = r.nextDouble();
-        }
-
-        Vector3d result = new Vector3dImpl(o1, o2, o3);
-
-//        if ((this.x ==Double.NaN) || (this.y == Double.NaN) || (this.z == Double.NaN)) {
-//            throw new IllegalStateException("NaN is not a valid entry for a vector.");
-//        }
-//        System.out.println(" this : "+ this);
-//        System.out.println(" result : "+ result);
-        // check if the created vector is really orthogonal to this
-        // if not try one more time
-        while (this.dot(result) != 0.0) {
-            result = this.orthogonal();
-        }
-
-        return result;
+      return  Math.abs(z()) < Math.abs(x())  ? Vector3d.xy(y(),-x()) : Vector3d.yz(-z(),y());
     }
 
     /**