Fix for v7.2.19 related issues

minio/commonconfig.py

@@ -466,22 +466,22 @@ def build_headers(self, object_size: int, etag: str):
     @property
     def object_size(self) -> Optional[int]:
         """Get object size."""
-        if self.object_size is None:
+        if self._object_size is None:
             raise MinioException(
                 "build_headers() must be called prior to "
                 "this method invocation",
             )
-        return self.object_size
+        return self._object_size
 
     @property
     def headers(self) -> dict[str, str]:
         """Get headers."""
-        if self.headers is None:
+        if self._headers is None:
             raise MinioException(
                 "build_headers() must be called prior to "
                 "this method invocation",
             )
-        return self.headers.copy()
+        return self._headers.copy()
 
     @classmethod
     def of(cls: Type[F], src: ObjectConditionalReadArgs) -> F:

minio/credentials/providers.py

@@ -113,7 +113,6 @@ class AssumeRoleProvider(Provider):
 
     def __init__(
             self,
-            *,
             sts_endpoint: str,
             access_key: str,
             secret_key: str,
@@ -396,7 +395,6 @@ class IamAwsProvider(Provider):
 
     def __init__(
             self,
-            *,
             custom_endpoint: Optional[str] = None,
             http_client: Optional[PoolManager] = None,
             auth_token: Optional[str] = None,
@@ -556,7 +554,6 @@ class LdapIdentityProvider(Provider):
 
     def __init__(
             self,
-            *,
             sts_endpoint: str,
             ldap_username: str,
             ldap_password: str,
@@ -628,7 +625,6 @@ class WebIdentityClientGrantsProvider(Provider, ABC):
 
     def __init__(
             self,
-            *,
             jwt_provider_func: Callable[[], dict[str, str]],
             sts_endpoint: str,
             duration_seconds: int = 0,
@@ -724,7 +720,6 @@ class ClientGrantsProvider(WebIdentityClientGrantsProvider):
 
     def __init__(
             self,
-            *,
             jwt_provider_func: Callable[[], dict[str, str]],
             sts_endpoint: str,
             duration_seconds: int = 0,
@@ -755,7 +750,6 @@ class CertificateIdentityProvider(Provider):
 
     def __init__(
             self,
-            *,
             sts_endpoint: str,
             cert_file: Optional[str] = None,
             key_file: Optional[str] = None,

minio/helpers.py

@@ -283,7 +283,6 @@ def update(self, length: int):
 
 
 def read_part_data(
-        *,
         stream: BinaryIO,
         size: int,
         part_data: bytes = b"",
@@ -436,7 +435,6 @@ def sha256_hash(data: Optional[str | bytes]) -> str:
 
 
 def url_replace(
-        *,
         url: urllib.parse.SplitResult,
         scheme: Optional[str] = None,
         netloc: Optional[str] = None,
@@ -678,7 +676,6 @@ def virtual_style_flag(self, flag: bool):
     @classmethod
     def _build_aws_url(
             cls,
-            *,
             aws_info: dict,
             url: urllib.parse.SplitResult,
             bucket_name: Optional[str],
@@ -742,7 +739,6 @@ def _build_list_buckets_url(
 
     def build(
             self,
-            *,
             method: str,
             region: str,
             bucket_name: Optional[str] = None,
@@ -820,7 +816,6 @@ class ObjectWriteResult:
     @classmethod
     def new(
             cls: Type[ObjectWriteResult],
-            *,
             headers: HTTPHeaderDict,
             bucket_name: str,
             object_name: str,

minio/minioadmin.py

@@ -116,7 +116,6 @@ class MinioAdmin:
 
     def __init__(
             self,
-            *,
             endpoint: str,
             credentials: Provider,
             region: str = "",
@@ -163,7 +162,6 @@ def __del__(self):
 
     def _url_open(
             self,
-            *,
             method: str,
             command: _COMMAND,
             query_params: Optional[HTTPQueryDict] = None,
@@ -789,7 +787,6 @@ def list_service_account(self, user: str) -> str:
         return plain_data.decode()
 
     def add_service_account(self,
-                            *,
                             access_key: Optional[str] = None,
                             secret_key: Optional[str] = None,
                             name: Optional[str] = None,
@@ -842,7 +839,6 @@ def add_service_account(self,
         return plain_data.decode()
 
     def update_service_account(self,
-                               *,
                                access_key: str,
                                secret_key: Optional[str] = None,
                                name: Optional[str] = None,

minio/signer.py

@@ -184,7 +184,6 @@ def _get_authorization(
 
 
 def _sign_v4(
-        *,
         service_name: str,
         method: str,
         url: SplitResult,
@@ -213,7 +212,6 @@ def _sign_v4(
 
 
 def sign_v4_s3(
-        *,
         method: str,
         url: SplitResult,
         region: str,
@@ -236,7 +234,6 @@ def sign_v4_s3(
 
 
 def sign_v4_sts(
-        *,
         method: str,
         url: SplitResult,
         region: str,
@@ -259,7 +256,6 @@ def sign_v4_sts(
 
 
 def _get_presign_canonical_request_hash(  # pylint: disable=invalid-name
-        *,
         method: str,
         url: SplitResult,
         access_key: str,
@@ -304,7 +300,6 @@ def _get_presign_canonical_request_hash(  # pylint: disable=invalid-name
 
 
 def presign_v4(
-        *,
         method: str,
         url: SplitResult,
         region: str,

pylintrc

@@ -186,6 +186,10 @@ bad-names=foo,bar,baz,toto,tutu,tata
 # Maximum number of arguments for function / method
 max-args=12
 
+# Maximum number of positional arguments for function / method
+# We allow more than the default 5 for backwards compatibility
+max-positional-arguments=16
+
 # Maximum number of locals for function / method body
 max-locals=30