added tables support v2

Author: HJLebbink

S3_TABLES_POC.md

@@ -91,7 +91,7 @@ The subdirectory approach keeps related code together and makes it easier to und
 
 Developers can easily distinguish:
 - **S3 operations**: `use minio::s3::{MinioClient, builders::*}`
-- **Tables operations**: `use minio::s3::tables::{TablesClient, builders::*}`
+- **Tables operations**: `use minio::s3tables::{TablesClient, builders::*}`
 
 The import paths immediately convey which API surface is being used.
 

TABLES_ARCHITECTURE_DECISION.md

@@ -201,7 +201,7 @@ pub enum Error {
     // ... existing variants ...
 
     #[error("Tables API error: {0}")]
-    TablesError(#[from] crate::s3::tables::error::TablesError),
+    TablesError(#[from] crate::s3tables::error::TablesError),
 }
 ```
 
@@ -300,7 +300,7 @@ Create `tests/tables_integration_test.rs`:
 #[cfg(test)]
 mod integration {
     use minio::s3::{MinioClient, creds::StaticProvider, http::BaseUrl};
-    use minio::s3::tables::TablesClient;
+    use minio::s3tables::TablesClient;
     use minio::s3::types::S3Api;
 
     async fn get_client() -> TablesClient {
@@ -394,8 +394,8 @@ Create `examples/tables_basic.rs`:
 
 ```rust
 use minio::s3::{MinioClient, creds::StaticProvider, http::BaseUrl};
-use minio::s3::tables::TablesClient;
-use minio::s3::tables::iceberg::{Schema, Field, FieldType, PrimitiveType};
+use minio::s3tables::TablesClient;
+use minio::s3tables::iceberg::{Schema, Field, FieldType, PrimitiveType};
 use minio::s3::types::S3Api;
 
 #[tokio::main]

TABLES_HTTP_IMPLEMENTATION_GUIDE.md

@@ -286,7 +286,7 @@ impl TablesClient {
     /// # Example
     /// ```no_run
     /// use minio::s3::MinioClient;
-    /// use minio::s3::tables::TablesClient;
+    /// use minio::s3tables::TablesClient;
     /// use minio::s3::creds::StaticProvider;
     /// use minio::s3::http::BaseUrl;
     ///
@@ -441,7 +441,7 @@ pub struct ErrorModel {
 
 **`src/s3/tables/builders/create_warehouse.rs`**:
 ```rust
-use crate::s3::tables::{TablesClient, TablesRequest, ToTablesRequest, TablesApi};
+use crate::s3tables::{TablesClient, TablesRequest, ToTablesRequest, TablesApi};
 use crate::s3::error::ValidationErr;
 use http::Method;
 use typed_builder::TypedBuilder;
@@ -457,7 +457,7 @@ pub struct CreateWarehouse {
 }
 
 impl TablesApi for CreateWarehouse {
-    type TablesResponse = crate::s3::tables::response::CreateWarehouseResponse;
+    type TablesResponse = crate::s3tables::response::CreateWarehouseResponse;
 }
 
 pub type CreateWarehouseBldr = CreateWarehouseBuilder<((TablesClient,), (String,), ())>;
@@ -490,14 +490,14 @@ impl ToTablesRequest for CreateWarehouse {
 
 **`src/s3/tables/client/create_warehouse.rs`**:
 ```rust
-use crate::s3::tables::{TablesClient, builders::CreateWarehouseBldr};
+use crate::s3tables::{TablesClient, builders::CreateWarehouseBldr};
 
 impl TablesClient {
     /// Creates a warehouse (table bucket)
     ///
     /// # Example
     /// ```no_run
-    /// use minio::s3::tables::TablesClient;
+    /// use minio::s3tables::TablesClient;
     /// use minio::s3::types::S3Api;
     ///
     /// # async fn example(client: TablesClient) {
@@ -511,7 +511,7 @@ impl TablesClient {
     /// # }
     /// ```
     pub fn create_warehouse<S: Into<String>>(&self, warehouse: S) -> CreateWarehouseBldr {
-        crate::s3::tables::builders::CreateWarehouse::builder()
+        crate::s3tables::builders::CreateWarehouse::builder()
             .client(self.clone())
             .warehouse_name(warehouse)
     }
@@ -520,7 +520,7 @@ impl TablesClient {
 
 **`src/s3/tables/response/create_warehouse.rs`**:
 ```rust
-use crate::s3::tables::{TablesRequest, FromTablesResponse};
+use crate::s3tables::{TablesRequest, FromTablesResponse};
 use crate::s3::error::Error;
 
 #[derive(Debug, Clone, serde::Deserialize)]
@@ -1062,7 +1062,7 @@ mod transaction_tests;
 
 // tests/tables/warehouse_tests.rs
 use minio::s3::MinioClient;
-use minio::s3::tables::TablesClient;
+use minio::s3tables::TablesClient;
 
 #[tokio::test]
 async fn test_warehouse_lifecycle() {
@@ -1126,7 +1126,7 @@ Create `examples/tables/` directory:
 ```rust
 // examples/tables/create_table.rs
 use minio::s3::MinioClient;
-use minio::s3::tables::{TablesClient, iceberg::*};
+use minio::s3tables::{TablesClient, iceberg::*};
 use minio::s3::creds::StaticProvider;
 use minio::s3::http::BaseUrl;
 use minio::s3::types::S3Api;
@@ -1214,7 +1214,7 @@ Add comprehensive rustdoc comments:
 /// # Examples
 ///
 /// ```no_run
-/// use minio::s3::tables::TablesClient;
+/// use minio::s3tables::TablesClient;
 /// use minio::s3::types::S3Api;
 ///
 /// # async fn example(tables: TablesClient) {
@@ -1258,7 +1258,7 @@ execute ACID transactions on structured data.
 
 \`\`\`rust
 use minio::s3::{MinioClient, creds::StaticProvider, http::BaseUrl};
-use minio::s3::tables::TablesClient;
+use minio::s3tables::TablesClient;
 
 let base_url = "http://localhost:9000/".parse()?;
 let provider = StaticProvider::new("minioadmin", "minioadmin", None);
@@ -1280,7 +1280,7 @@ tables.create_namespace("analytics", "sales").build().send().await?;
 
 #### Create a Table
 \`\`\`rust
-use minio::s3::tables::iceberg::*;
+use minio::s3tables::iceberg::*;
 
 let schema = Schema {
     schema_id: 0,
@@ -1312,7 +1312,7 @@ tables
 MinIO AIStor supports atomic transactions across multiple tables:
 
 \`\`\`rust
-use minio::s3::tables::iceberg::{Requirement, Update};
+use minio::s3tables::iceberg::{Requirement, Update};
 
 tables
     .commit_multi_table_transaction("warehouse")

TABLES_IMPLEMENTATION_PLAN.md

@@ -44,8 +44,8 @@ All phases (1-11) of the Tables API implementation are complete, providing a ful
 
 ```rust
 use minio::s3::{MinioClient, creds::StaticProvider, http::BaseUrl};
-use minio::s3::tables::{TablesApi, TablesClient};
-use minio::s3::tables::iceberg::{Schema, Field, FieldType, PrimitiveType};
+use minio::s3tables::{TablesApi, TablesClient};
+use minio::s3tables::iceberg::{Schema, Field, FieldType, PrimitiveType};
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {

TABLES_README.md

@@ -36,8 +36,8 @@
 use minio::s3::MinioClient;
 use minio::s3::creds::StaticProvider;
 use minio::s3::http::BaseUrl;
-use minio::s3::tables::iceberg::{Field, FieldType, PrimitiveType, Schema};
-use minio::s3::tables::{TablesApi, TablesClient};
+use minio::s3tables::iceberg::{Field, FieldType, PrimitiveType, Schema};
+use minio::s3tables::{TablesApi, TablesClient};
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {
@@ -113,8 +113,9 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .send()
         .await?;
 
-    println!("   Found {} table(s):", list_response.identifiers.len());
-    for table_id in &list_response.identifiers {
+    let identifiers = list_response.identifiers()?;
+    println!("   Found {} table(s):", identifiers.len());
+    for table_id in &identifiers {
         println!(
             "     - {}.{}",
             table_id.namespace_schema.join("."),
@@ -130,10 +131,10 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .build()
         .send()
         .await?;
+    let table_result = table_meta.table_result()?;
     println!(
         "   ✓ Metadata location: {}",
-        table_meta
-            .0
+        table_result
             .metadata_location
             .unwrap_or_else(|| "N/A".to_string())
     );
@@ -146,10 +147,10 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .build()
         .send()
         .await?;
-    println!("   Row count: {}", metrics.row_count);
-    println!("   Size: {} bytes", metrics.size_bytes);
-    println!("   Files: {}", metrics.file_count);
-    println!("   Snapshots: {}", metrics.snapshot_count);
+    println!("   Row count: {}", metrics.row_count()?);
+    println!("   Size: {} bytes", metrics.size_bytes()?);
+    println!("   Files: {}", metrics.file_count()?);
+    println!("   Snapshots: {}", metrics.snapshot_count()?);
     println!();
 
     // Step 9: Cleanup

examples/tables_quickstart.rs

@@ -63,6 +63,7 @@
 #![allow(clippy::result_large_err)]
 #![allow(clippy::too_many_arguments)]
 pub mod s3;
+pub mod s3tables;
 
 #[cfg(test)]
 #[macro_use]

src/lib.rs

@@ -773,7 +773,7 @@ impl MinioClient {
             let body_text = response.text().await.map_err(NetworkError::ReqwestError)?;
 
             if let Ok(error_resp) =
-                serde_json::from_str::<crate::s3::tables::error::TablesErrorResponse>(&body_text)
+                serde_json::from_str::<crate::s3tables::error::TablesErrorResponse>(&body_text)
             {
                 return Err(Error::TablesError(error_resp.into()));
             }

src/s3/client.rs

@@ -337,7 +337,7 @@ pub enum Error {
     Validation(#[from] ValidationErr),
 
     #[error("Tables API error: {0}")]
-    TablesError(#[from] crate::s3::tables::error::TablesError),
+    TablesError(#[from] crate::s3tables::error::TablesError),
 }
 
 // region message helpers

src/s3/error.rs

@@ -29,7 +29,6 @@ pub mod response;
 pub mod segmented_bytes;
 pub mod signer;
 pub mod sse;
-pub mod tables;
 pub mod types;
 pub mod utils;