Skip to content

Commit 8360733

Browse files
authored
Disable implicit suffix rules in submakefiles (#1902)
I believe this was causing issues, e.g., [here](https://github.com/mit-plv/fiat-crypto/actions/runs/9023963682/job/24799935044?pr=1898#step:5:39) when uploaded artifacts failed to preserve relative timestamps on .o files vs output executables, and as a result invoked automatic [suffix rules](https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html) and failed.
1 parent d70c5eb commit 8360733

5 files changed

+10
-0
lines changed

Makefile.config

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
.SUFFIXES:
2+
13
SKIP_BEDROCK2?=
24

35
VERBOSE?=

Makefile.coq.local

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
.SUFFIXES:
2+
13
PROFILE?=
24
OTHERFLAGS += -w -notation-overridden,-deprecated-hint-constr,-fragile-hint-constr,-native-compiler-disabled,-ambiguous-paths,-masking-absolute-name
35
ifneq ($(PROFILE),)

Makefile.examples

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
# this makefile directly as long as the compiled binaries are lying
55
# around
66

7+
.SUFFIXES:
8+
79
include Makefile.config
810

911
CFLAGS?=

Makefile.js-html

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
.SUFFIXES:
2+
13
EXTRA_HTML_VERSION_INFO?=
24

35
.PHONY: fiat-html/version.js

Makefile.standalone

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
# files on .v files, so that we can compile them by invoking this
33
# makefile directly even when Coq is not available
44

5+
.SUFFIXES:
6+
57
SELF_MAKEFILE_STANDALONE := $(lastword $(MAKEFILE_LIST))
68

79
include Makefile.config

0 commit comments

Comments
 (0)