Do not encourage disabling constraint checks

Author: josevalim

integration_test/pg/constraints_test.exs

@@ -41,7 +41,7 @@ defmodule Ecto.Integration.ConstraintsTest do
     :ok
   end
 
-  test "creating, using, and dropping an exclusion constraint" do
+  test "exclusion constraint" do
     changeset = Ecto.Changeset.change(%Constraint{}, from: 0, to: 10)
     {:ok, _} = PoolRepo.insert(changeset)
 
@@ -75,7 +75,7 @@ defmodule Ecto.Integration.ConstraintsTest do
     assert changeset.data.__meta__.state == :built
   end
 
-  test "creating, using, and dropping a check constraint" do
+  test "check constraint" do
     # When the changeset doesn't expect the db error
     changeset = Ecto.Changeset.change(%Constraint{}, price: -10)
     exception =

integration_test/tds/constraints_test.exs

@@ -16,24 +16,6 @@ defmodule Ecto.Integration.ConstraintsTest do
         add :to, :integer
       end
       create constraint(@table.name, :cannot_overlap, check: "[from] < [to]")
-      create constraint(@table.name, "positive_price", check: "[price] > 0")
-    end
-  end
-
-  defmodule ConstraintMigration2 do
-    use Ecto.Migration
-
-    def change do
-      opts = [with: "NOCHECK", check: "[from] < 200"]
-      create constraint(:constraints_test, "from_max", opts)
-    end
-  end
-
-  defmodule ConstraintMigration3 do
-    use Ecto.Migration
-
-    def change do
-      drop constraint(:constraints_test, "from_max")
     end
   end
 
@@ -58,7 +40,7 @@ defmodule Ecto.Integration.ConstraintsTest do
     :ok
   end
 
-  test "creating, using, and dropping an exclusion constraint" do
+  test "check constraint" do
     changeset = Ecto.Changeset.change(%Constraint{}, from: 0, to: 10)
     {:ok, _} = PoolRepo.insert(changeset)
 
@@ -75,84 +57,11 @@ defmodule Ecto.Integration.ConstraintsTest do
     assert exception.message =~ "The changeset has not defined any constraint."
     assert exception.message =~ "call `check_constraint/3`"
 
-    # Seems like below `Ecto.Changeset.check_constraint(:from)` is not valid for some reason,
-    # constrint name is mandatory and ecto raises ArgumentError
-
-    # message = ~r/constraint error when attempting to insert struct/
-    # exception =
-    #   assert_raise Ecto.ConstraintError, message, fn ->
-    #     overlapping_changeset
-    #     |> Ecto.Changeset.check_constraint(:from)
-    #     |> PoolRepo.insert()
-    #   end
-    # assert exception.message =~ "cannot_overlap (check_constraint)"
-
     {:error, changeset} =
       overlapping_changeset
       |> Ecto.Changeset.check_constraint(:from, name: :cannot_overlap)
       |> PoolRepo.insert()
     assert changeset.errors == [from: {"is invalid", [constraint: :check, constraint_name: "cannot_overlap"]}]
     assert changeset.data.__meta__.state == :built
-
-    ExUnit.CaptureLog.capture_log(fn ->
-      # migrate over existing data, it should pass since `with: NOCHECK` is set
-      num = @base_migration + System.unique_integer([:positive])
-      assert :ok == up(PoolRepo, num, ConstraintMigration2, log: false)
-    end)
-
-    # from is greated than max allowed by database, so check constrint should
-    # forbid insert
-    from_max_changeset = Ecto.Changeset.change(%Constraint{}, from: 300, to: 400)
-
-    exception =
-      assert_raise Ecto.ConstraintError, ~r/constraint error when attempting to insert struct/, fn ->
-        PoolRepo.insert(from_max_changeset)
-      end
-    assert exception.message =~ "from_max (check_constraint)"
-    assert exception.message =~ "The changeset has not defined any constraint."
-    assert exception.message =~ "call `check_constraint/3`"
-
-    ExUnit.CaptureLog.capture_log(fn ->
-      num = @base_migration + System.unique_integer([:positive])
-      assert :ok == up(PoolRepo, num, ConstraintMigration3, log: false)
-    end)
-  end
-
-  test "creating, using, and dropping a check constraint" do
-    # When the changeset doesn't expect the db error
-    changeset = Ecto.Changeset.change(%Constraint{}, price: -10)
-    exception =
-      assert_raise Ecto.ConstraintError, ~r/constraint error when attempting to insert struct/, fn ->
-        PoolRepo.insert(changeset)
-      end
-
-    assert exception.message =~ "positive_price (check_constraint)"
-    assert exception.message =~ "The changeset has not defined any constraint."
-    assert exception.message =~ "call `check_constraint/3`"
-
-    # When the changeset does expect the db error, but doesn't give a custom message
-    {:error, changeset} =
-      changeset
-      |> Ecto.Changeset.check_constraint(:price, name: :positive_price)
-      |> PoolRepo.insert()
-    assert changeset.errors == [price: {"is invalid", [constraint: :check, constraint_name: "positive_price"]}]
-    assert changeset.data.__meta__.state == :built
-
-    # When the changeset does expect the db error and gives a custom message
-    changeset = Ecto.Changeset.change(%Constraint{}, price: -10)
-    {:error, changeset} =
-      changeset
-      |> Ecto.Changeset.check_constraint(:price, name: :positive_price, message: "price must be greater than 0")
-      |> PoolRepo.insert()
-    assert changeset.errors == [price: {"price must be greater than 0", [constraint: :check, constraint_name: "positive_price"]}]
-    assert changeset.data.__meta__.state == :built
-
-    # When the change does not violate the check constraint
-    changeset = Ecto.Changeset.change(%Constraint{}, price: 10, from: 100, to: 200)
-    {:ok, changeset} =
-      changeset
-      |> Ecto.Changeset.check_constraint(:price, name: :positive_price, message: "price must be greater than 0")
-      |> PoolRepo.insert()
-    assert is_integer(changeset.id)
   end
 end

lib/ecto/adapters/tds/connection.ex

@@ -1040,20 +1040,13 @@ if Code.ensure_loaded?(Tds) do
       error!(nil, msg)
     end
 
-    def execute_ddl({:create, %Constraint{with: nocheck}})
-        when nocheck not in [nil, "NOCHECK"] do
-      error!(nil, ~s{Check constraint `:with` valid values are `nil` and "NOCHECK"})
-    end
-
     def execute_ddl({:create, %Constraint{} = constraint}) do
-      with_nocheck = if_do(constraint.with != nil, [" WITH NOCHECK"])
       table_name = quote_table(constraint.prefix, constraint.table)
 
       [
         [
           "ALTER TABLE ",
           table_name,
-          with_nocheck,
           " ADD CONSTRAINT ",
           quote_name(constraint.name),
           " ",

lib/ecto/migration.ex

@@ -362,10 +362,9 @@ defmodule Ecto.Migration do
 
     To define a constraint in a migration, see `Ecto.Migration.constraint/3`.
     """
-    defstruct name: nil, table: nil, check: nil, exclude: nil, prefix: nil, comment: nil, with: nil
+    defstruct name: nil, table: nil, check: nil, exclude: nil, prefix: nil, comment: nil
     @type t :: %__MODULE__{name: atom, table: String.t, prefix: atom | nil,
-                           check: String.t | nil, exclude: String.t | nil, comment: String.t | nil,
-                           with: String.t | nil}
+                           check: String.t | nil, exclude: String.t | nil, comment: String.t | nil}
   end
 
   defmodule Command do
@@ -1116,9 +1115,6 @@ defmodule Ecto.Migration do
     * `:check` - A check constraint expression. Required when creating a check constraint.
     * `:exclude` - An exclusion constraint expression. Required when creating an exclusion constraint.
     * `:prefix` - The prefix for the table.
-    * `:with` - Optional parameter for Tds adapter for create constrint.
-                Valid value is `"NOCHECK"` and it will prevent constraint checking
-                existing rows in the table, and allow for constrint to be added.
 
   """
   def constraint(table, name, opts \\ [])