Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring suggestions for inline class failed to consider inheritance #2

Open
moar82 opened this issue Mar 25, 2021 · 0 comments
Open
Labels

Comments

@moar82
Copy link
Owner

moar82 commented Mar 25, 2021

Description

When SAD detects lazy class, RefGen proposes to inline the class to the class that makes use of it. However, there are some cases where the classes do not implement any method, but extend a parent class with the functionality used in the target class to inline the supposedly "lazy class" (source class). This is a case of false positive that could be fixed directly in SAD from PtiDej, (a.k.a, DECOR). From the refactoring suggestion engine (a.k.a, SACO) it could be validated if source class extends another class do not propose the refactoring.

###Affects
Eclipse Plug-in, Simulation mode (command line), SAD (PtiDej)

###Reproducibility
at-robotsj, forked from sourceforge in my github account.
Check the following commit moar82/at-robots@522a07e the refactored was applied using RefGen, broken the build.

@moar82 moar82 added the bug label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant