refactor: address PR review feedback

- Extract error message creation into createHookSkipError() helper function to eliminate duplication across three locations
- Simplify recursive forEach call in failAffectedTests()
- Update test fixture and suite descriptions to use backticks for clarity (e.g., 'error in `before` hook')

Author: akshah123

lib/runner.js

@@ -442,6 +442,22 @@ Runner.prototype.checkGlobals = function (test) {
   }
 };
 
+/**
+ * Create an error object for a test that was skipped due to a hook failure.
+ *
+ * @private
+ * @param {string} hookTitle - The title of the failed hook
+ * @param {Error} hookError - The error from the failed hook
+ * @returns {Error} The error object for the skipped test
+ */
+function createHookSkipError(hookTitle, hookError) {
+  var errorMessage =
+    'Test skipped due to failure in "' + hookTitle + '": ' + hookError.message;
+  var testError = new Error(errorMessage);
+  testError.stack = hookError.stack;
+  return testError;
+}
+
 /**
  * Fail all tests that are affected by a hook failure.
  * This is used when the `failHookAffectedTests` option is enabled.
@@ -457,10 +473,7 @@ Runner.prototype.failAffectedTests = function (suite, hookError, hookTitle) {
   }
 
   var self = this;
-  var errorMessage =
-    'Test skipped due to failure in "' + hookTitle + '": ' + hookError.message;
-  var testError = new Error(errorMessage);
-  testError.stack = hookError.stack;
+  var testError = createHookSkipError(hookTitle, hookError);
 
   // Recursively fail all tests in this suite and its child suites
   function failTestsInSuite(s) {
@@ -475,9 +488,7 @@ Runner.prototype.failAffectedTests = function (suite, hookError, hookTitle) {
       }
     });
 
-    s.suites.forEach(function (childSuite) {
-      failTestsInSuite(childSuite);
-    });
+    s.suites.forEach(failTestsInSuite);
   }
 
   failTestsInSuite(suite);
@@ -632,13 +643,7 @@ Runner.prototype.hook = function (name, fn) {
           } else if (name === HOOK_TYPE_BEFORE_EACH) {
             // Fail the current test
             if (self.test && !self.test.state) {
-              var errorMessage =
-                'Test skipped due to failure in "' +
-                hook.title +
-                '": ' +
-                err.message;
-              var testError = new Error(errorMessage);
-              testError.stack = err.stack;
+              var testError = createHookSkipError(hook.title, err);
 
               self.test.state = STATE_FAILED;
               self.failures++;
@@ -819,13 +824,10 @@ Runner.prototype.runTests = function (suite, fn) {
       var remainingTests = tests.slice();
       remainingTests.forEach(function (t) {
         if (!t.state) {
-          var errorMessage =
-            'Test skipped due to failure in "' +
-            self._failedBeforeEachHook.title +
-            '": ' +
-            self._failedBeforeEachHook.error.message;
-          var testError = new Error(errorMessage);
-          testError.stack = self._failedBeforeEachHook.error.stack;
+          var testError = createHookSkipError(
+            self._failedBeforeEachHook.title,
+            self._failedBeforeEachHook.error
+          );
 
           t.state = STATE_FAILED;
           self.failures++;

test/integration/fixtures/hooks/before-each-hook-error-with-fail-affected.fixture.js

@@ -1,8 +1,8 @@
 'use strict';
 
-describe('spec 1', function () {
+describe('fails `beforeEach` hook', function () {
   beforeEach(function () {
-    throw new Error('before each hook error');
+    throw new Error('error in `beforeEach` hook');
   });
   it('test 1', function () {
     // This should be reported as failed due to beforeEach hook failure
@@ -11,7 +11,7 @@ describe('spec 1', function () {
     // This should be reported as failed due to beforeEach hook failure
   });
 });
-describe('spec 2', function () {
+describe('passes normally', function () {
   it('test 3', function () {
     // This should pass normally
   });

test/integration/fixtures/hooks/before-hook-error-with-fail-affected.fixture.js

@@ -1,8 +1,8 @@
 'use strict';
 
-describe('spec 1', function () {
+describe('fails `before` hook', function () {
   before(function () {
-    throw new Error('before hook error');
+    throw new Error('error in `before` hook');
   });
   it('test 1', function () {
     // This should be reported as failed due to before hook failure
@@ -11,7 +11,7 @@ describe('spec 1', function () {
     // This should be reported as failed due to before hook failure
   });
 });
-describe('spec 2', function () {
+describe('passes normally', function () {
   it('test 3', function () {
     // This should pass normally
   });

test/integration/hook-err.spec.js

@@ -268,7 +268,7 @@ describe("hook error handling", function () {
   });
 
   describe("--fail-hook-affected-tests", function () {
-    describe("before hook error", function () {
+    describe("error in `before` hook", function () {
       it("should fail all affected tests", function (done) {
         runMochaJSON(
           "hooks/before-hook-error-with-fail-affected",
@@ -290,7 +290,7 @@ describe("hook error handling", function () {
       });
     });
 
-    describe("beforeEach hook error", function () {
+    describe("error in `beforeEach` hook", function () {
       it("should fail all affected tests", function (done) {
         runMochaJSON(
           "hooks/before-each-hook-error-with-fail-affected",