Skip to content

Commit a68dc10

Browse files
committed
add comment on session duration
1 parent 4a084bb commit a68dc10

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/ModelContextProtocol/Shared/McpSession.cs

+3
Original file line numberDiff line numberDiff line change
@@ -645,6 +645,9 @@ public void Dispose()
645645
{
646646
TagList tags = default;
647647
tags.Add("network.transport", _transportKind);
648+
649+
// TODO (lmolkova): add server.address and server.port on client-side when using SSE transport,
650+
// client.* attributes are not added to metrics because of cardinality
648651
durationMetric.Record(GetElapsed(_sessionStartingTimestamp).TotalSeconds, tags);
649652
}
650653

0 commit comments

Comments
 (0)