-
Notifications
You must be signed in to change notification settings - Fork 343
Major issue -dependency on reactor, slf4j and netty #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…ut in a very trivial way. modified: README.md modified: mcp/pom.xml @hrstoyanov wrote: > This project requires reactor (and therefore - netty), slf4j for reasons I cannot understand. In its current state it is more like "Spring MCP SDK" rather than "Java MCP SDK", so at least change the project title. I realize @tzolov proposed a [remedy](https://github.com/orgs/modelcontextprotocol/discussions/246#discussioncomment-12854366), but even that seems problematic because it introduces a dependency on RS Publisher. In the meantime, please consider this trivial PR, which implements "at least change the project title." Signed-off-by: Ed Burns <[email protected]>
Hello @hrstoyanov please consider this PR: #175 . |
Changing the title is the proper way for this situation |
Hi! I created a PR that I hope will help with this! |
@Aliaksie the proper way is to avoid any of the reactive frameworks, but use java virtual threads. Likewise , remove slf4j and use java System.Logger facade |
hi @hrstoyanov, thank you for the feedback! You're absolutely right about minimizing dependencies — and that’s exactly what my PR is structured to enable:
This opens the door to a fully java-based module (i.e. mcp-java). I’d love to collaborate on that — but first, we need agreement on this decoupling PR . cc @tzolov |
This project requires reactor (and therefore - netty), slf4j for reasons I cannot understand. In its current state it is more like "Spring MCP SDK" rather than "Java MCP SDK", so at least change the project title.
Java already has virtual threads and therefore, there is no need for any reactive frameworks. Also, since Java 9+ there is also a built-in logging facade
System.Logger
, so there is no need for slf4j either.The use of jackson is also problematic - ideally there should be 2 modules - for jackson and standard jsonp.
Please clean it up.
The text was updated successfully, but these errors were encountered: