Updated ServerPromptsTest, move AbstractTransport to it's own file #376
+282
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpavlov
added
tests
enhancement
10 tasks
kpavlov
force-pushed
the
kpavlov/refactor
branch
2 times, most recently
from
9ce7ee7 to
7d315c0
Compare
devcrocod
reviewed
Nov 10, 2025
| @@ -80,21 +157,55 @@ class ServerPromptsTest : AbstractServerFeaturesTest() { | |||
| assertFalse(promptListChangedNotificationReceived, "No notification should be sent when prompt doesn't exist") | |||
| } | |||
|
|
|||
| @Test | |||
| fun `removePrompt should throw when prompts capability is not supported`() = runTest { | |||
| @Nested | |||
Contributor
There was a problem hiding this comment.
Why do we need inner class? Maybe it would be better to separate it?
Contributor
Author
There was a problem hiding this comment.
It's a good idea. Let's do it in follow-up PR
kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/Server.kt
Outdated
Show resolved
Hide resolved
kpavlov
force-pushed
the
kpavlov/refactor
branch
2 times, most recently
from
7751d02 to
eecbbee
Compare
kpavlov
force-pushed
the
kpavlov/refactor
branch
from
eecbbee to
e75b364
Compare
…d modularize `AbstractTransport` - Extracted `AbstractTransport` to a dedicated file for modularity. - Improved prompt validation with `require` statement and updated related tests. - Bump jvmTarget to 11 - Fixed typos and improved test cases for better clarity. - Deprecate `_meta` in favor of `meta` with fallback implementation; update tests to handle `McpException`.
kpavlov
force-pushed
the
kpavlov/refactor
branch
from
e75b364 to
db84dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and enhance prompt handling logic and tests, update Kotest version and modularize
AbstractTransportAbstractTransportto a dedicated file for modularity.IllegalStateExceptioninstead ofError.Motivation and Context
Improve test scenarios in ServerPromptsTest
How Has This Been Tested?
Integration tests updated
Breaking Changes
When disconnected, the Protocol will throw
IllegalStateExceptioninstead ofError.Types of changes
Checklist
Additional context