Add backwards compatibility constructors and tests #395
+250
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated integration tests to include assertions for `meta` being `null` in the `listTools`, `listResources`, `readResource`, and `callTool` results. - Renamed test cases in `SseServerIntegrationTest` for clarity.
…transport null check.
kpavlov
changed the title
…ity for paginated request parameters, and enhance `meta` handling across SDK components.
devcrocod
approved these changes
Nov 12, 2025
Contributor
devcrocod
left a comment
devcrocod
left a comment
There was a problem hiding this comment.
I only have some comments about the code style
| * The argument's information for which completion options are requested. | ||
| */ | ||
| public val argument: CompleteRequestParams.Argument | ||
| public val argument: Argument |
Contributor
There was a problem hiding this comment.
It’s better to refer to the class directly rather than importing it separately
this makes the code clearer and easier to understand:
CompleteRequestParams.Argument
Contributor
Author
There was a problem hiding this comment.
Idea complains about it but yes
| * Additional, context for generating completions. | ||
| */ | ||
| public val context: CompleteRequestParams.Context? | ||
| public val context: Context? |
Contributor
There was a problem hiding this comment.
The same as with Argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metabeingnullin thelistTools,listResources,readResource, andcallToolresults.SseServerIntegrationTestfor clarity.throw Error(...)witherror(...)for cleaner error handling.Motivation and Context
To verify backwards-compatibility after schema change
How Has This Been Tested?
CI, integration tests, regression tests (samples)
Breaking Changes
Types of changes
Checklist
Additional context