From b14023acabf5600d3ae500f6f5bd9047f34dbd8f Mon Sep 17 00:00:00 2001
From: HoberMin <102784200+HoberMin@users.noreply.github.com>
Date: Mon, 7 Apr 2025 23:39:02 +0900
Subject: [PATCH] feat: Add error handling tests for InMemoryTransport

---
 src/inMemory.test.ts | 98 +++++++++++++++++++++++++++++++++++++++++++-
 src/inMemory.ts      |  4 +-
 2 files changed, 99 insertions(+), 3 deletions(-)

diff --git a/src/inMemory.test.ts b/src/inMemory.test.ts
index f7e9e979..f7d86718 100644
--- a/src/inMemory.test.ts
+++ b/src/inMemory.test.ts
@@ -69,10 +69,43 @@ describe("InMemoryTransport", () => {
   });
 
   test("should throw error when sending after close", async () => {
-    await clientTransport.close();
+    const [client, server] = InMemoryTransport.createLinkedPair();
+    let clientError: Error | undefined;
+    let serverError: Error | undefined;
+
+    client.onerror = (err) => {
+      clientError = err;
+    };
+
+    server.onerror = (err) => {
+      serverError = err;
+    };
+
+    await client.close();
+
+    // Attempt to send message from client
     await expect(
-      clientTransport.send({ jsonrpc: "2.0", method: "test", id: 1 }),
+      client.send({
+        jsonrpc: "2.0",
+        method: "test",
+        id: 1,
+      }),
     ).rejects.toThrow("Not connected");
+
+    // Attempt to send message from server
+    await expect(
+      server.send({
+        jsonrpc: "2.0",
+        method: "test",
+        id: 2,
+      }),
+    ).rejects.toThrow("Not connected");
+
+    // Verify that both sides received errors
+    expect(clientError).toBeDefined();
+    expect(clientError?.message).toBe("Not connected");
+    expect(serverError).toBeDefined();
+    expect(serverError?.message).toBe("Not connected");
   });
 
   test("should queue messages sent before start", async () => {
@@ -91,4 +124,65 @@ describe("InMemoryTransport", () => {
     await serverTransport.start();
     expect(receivedMessage).toEqual(message);
   });
+
+  describe("error handling", () => {
+    test("should trigger onerror when sending without connection", async () => {
+      const transport = new InMemoryTransport();
+      let error: Error | undefined;
+
+      transport.onerror = (err) => {
+        error = err;
+      };
+
+      await expect(
+        transport.send({
+          jsonrpc: "2.0",
+          method: "test",
+          id: 1,
+        }),
+      ).rejects.toThrow("Not connected");
+
+      expect(error).toBeDefined();
+      expect(error?.message).toBe("Not connected");
+    });
+
+    test("should trigger onerror when sending after close", async () => {
+      const [client, server] = InMemoryTransport.createLinkedPair();
+      let clientError: Error | undefined;
+      let serverError: Error | undefined;
+
+      client.onerror = (err) => {
+        clientError = err;
+      };
+
+      server.onerror = (err) => {
+        serverError = err;
+      };
+
+      await client.close();
+
+      // Attempt to send message from client
+      await expect(
+        client.send({
+          jsonrpc: "2.0",
+          method: "test",
+          id: 1,
+        }),
+      ).rejects.toThrow("Not connected");
+
+      // Attempt to send message from server
+      await expect(
+        server.send({
+          jsonrpc: "2.0",
+          method: "test",
+          id: 2,
+        }),
+      ).rejects.toThrow("Not connected");
+
+      // Verify that both sides received errors
+      expect(clientError?.message).toBe("Not connected");
+      expect(serverError).toBeDefined();
+      expect(serverError?.message).toBe("Not connected");
+    });
+  });
 });
diff --git a/src/inMemory.ts b/src/inMemory.ts
index 65915baa..3b14c2d2 100644
--- a/src/inMemory.ts
+++ b/src/inMemory.ts
@@ -44,7 +44,9 @@ export class InMemoryTransport implements Transport {
 
   async send(message: JSONRPCMessage): Promise<void> {
     if (!this._otherTransport) {
-      throw new Error("Not connected");
+      const error = new Error("Not connected");
+      this.onerror?.(error);
+      throw error;
     }
 
     if (this._otherTransport.onmessage) {