Skip to content

Commit 43e0827

Browse files
author
Sander Aalbers
committed
Remove Puppeteer KnownDevices export
1 parent 9dd1013 commit 43e0827

File tree

6 files changed

+26
-7
lines changed

6 files changed

+26
-7
lines changed

docs/docs/test-runner/browser-launchers/chrome.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,15 @@ Some examples:
8181
### Emulate mobile browser
8282

8383
```js
84-
import { chromeLauncher, devices } from '@web/test-runner-chrome';
84+
import { chromeLauncher } from '@web/test-runner-chrome';
85+
import { KnownDevices } from 'puppeteer';
8586

8687
export default {
8788
browsers: [
8889
chromeLauncher({
8990
async createPage({ context }) {
9091
const page = await context.newPage();
91-
page.emulate(devices['Pixel 2']);
92+
page.emulate(KnownDevices['Pixel 2']);
9293
return page;
9394
},
9495
}),

docs/docs/test-runner/browser-launchers/puppeteer.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,15 @@ Some examples:
7575
### Emulate mobile browser
7676

7777
```js
78-
import { puppeteerLauncher, devices } from '@web/test-runner-puppeteer';
78+
import { puppeteerLauncher } from '@web/test-runner-puppeteer';
79+
import { KnownDevices } from 'puppeteer';
7980

8081
export default {
8182
browsers: [
8283
puppeteerLauncher({
8384
async createPage({ context }) {
8485
const page = await context.newPage();
85-
page.emulate(devices['Pixel 2']);
86+
page.emulate(KnownDevices['Pixel 2']);
8687
return page;
8788
},
8889
}),
+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Migration
2+
3+
## From version 0.15.x to 0.16.0
4+
5+
The re-exports of Puppeteer devices is removed and can be imported from Puppeteer directly.
6+
7+
```ts
8+
import { KnownDevices } from 'puppeteer';
9+
```

packages/test-runner-chrome/src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as puppeteerCore from 'puppeteer-core';
22
import { ChromeLauncher, CreateBrowserContextFn, CreatePageFn } from './ChromeLauncher.js';
3-
import { PuppeteerNodeLaunchOptions, KnownDevices } from 'puppeteer-core';
3+
import { PuppeteerNodeLaunchOptions } from 'puppeteer-core';
44

55
export interface ChromeLauncherArgs {
66
puppeteer?: typeof puppeteerCore;
@@ -10,7 +10,7 @@ export interface ChromeLauncherArgs {
1010
concurrency?: number;
1111
}
1212

13-
export { ChromeLauncher, KnownDevices, puppeteerCore };
13+
export { ChromeLauncher, puppeteerCore };
1414

1515
export function chromeLauncher(args: ChromeLauncherArgs = {}) {
1616
const {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Migration
2+
3+
## From version 0.15.x to 0.16.0
4+
5+
The re-exports of Puppeteer devices is removed and can be imported from Puppeteer directly.
6+
7+
```ts
8+
import { KnownDevices } from 'puppeteer';
9+
```
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
export { puppeteerLauncher } from './puppeteerLauncher.js';
2-
export { KnownDevices } from 'puppeteer';

0 commit comments

Comments
 (0)