Merge pull request #2696 from modernweb-dev/fix/storybook-builder-NODE_PATH

fix(storybook-builder): clean up NODE_PATH from bundled modules output

Author: bashmish

.changeset/fuzzy-poems-decide.md

@@ -0,0 +1,5 @@
+---
+'@web/storybook-builder': patch
+---
+
+clean up NODE_PATH from bundled modules output

packages/storybook-builder/src/rollup-plugin-prebundle-modules.ts

@@ -42,9 +42,15 @@ export function rollupPluginPrebundleModules(env: Record<string, string>): Plugi
             '@storybook/react-dom-shim': getReactDomShimAlias(),
           }),
         },
-        define: {
-          ...stringifyProcessEnvs(env),
-        },
+        define: (() => {
+          const define = stringifyProcessEnvs(env);
+
+          // "NODE_PATH" pollutes the output, it's not used by prebundled modules and is not recommended in general
+          // see more https://github.com/nodejs/node/issues/38128#issuecomment-814969356
+          delete define['process.env.NODE_PATH'];
+
+          return define;
+        })(),
         plugins: [
           esbuildPluginCommonjsNamedExports(
             modules.filter(