Skip to content

Commit a6941e5

Browse files
committed
feat!: upgrade puppeteer version to v24
1 parent a145518 commit a6941e5

File tree

9 files changed

+459
-175
lines changed

9 files changed

+459
-175
lines changed

package-lock.json

+443-159
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/browser-logs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@
5151
},
5252
"devDependencies": {
5353
"@esm-bundle/chai": "^4.1.5",
54-
"puppeteer": "^22.0.0"
54+
"puppeteer": "^24.0.0"
5555
}
5656
}

packages/dev-server-hmr/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@
4444
},
4545
"devDependencies": {
4646
"lit-html": "^2.7.3 || ^3.0.0",
47-
"puppeteer": "^22.0.0"
47+
"puppeteer": "^24.0.0"
4848
}
4949
}

packages/dev-server/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,6 @@
7373
"devDependencies": {
7474
"@types/command-line-usage": "^5.0.1",
7575
"lit-html": "^2.7.3 || ^3.0.0",
76-
"puppeteer": "^22.0.0"
76+
"puppeteer": "^24.0.0"
7777
}
7878
}

packages/test-runner-chrome/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@web/test-runner-coverage-v8": "^0.8.0",
5151
"async-mutex": "0.4.0",
5252
"chrome-launcher": "^0.15.0",
53-
"puppeteer-core": "^23.2.0"
53+
"puppeteer-core": "^24.0.0"
5454
},
5555
"devDependencies": {
5656
"@types/istanbul-reports": "^3.0.0",

packages/test-runner-chrome/src/ChromeLauncher.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as puppeteerCore from 'puppeteer-core';
22
import {
33
Browser,
44
Page,
5-
PuppeteerNodeLaunchOptions,
5+
LaunchOptions,
66
launch as puppeteerCoreLaunch,
77
BrowserContext,
88
} from 'puppeteer-core';
@@ -31,7 +31,7 @@ export class ChromeLauncher implements BrowserLauncher {
3131
public name: string;
3232
public type = 'puppeteer';
3333
public concurrency?: number;
34-
private launchOptions: PuppeteerNodeLaunchOptions;
34+
private launchOptions: LaunchOptions;
3535
private customPuppeteer?: typeof puppeteerCore;
3636
private createBrowserContextFn: CreateBrowserContextFn;
3737
private createPageFn: CreatePageFn;
@@ -48,7 +48,7 @@ export class ChromeLauncher implements BrowserLauncher {
4848
private __startBrowserPromise?: Promise<{ browser: Browser; context: BrowserContext }>;
4949

5050
constructor(
51-
launchOptions: PuppeteerNodeLaunchOptions,
51+
launchOptions: LaunchOptions,
5252
createBrowserContextFn: CreateBrowserContextFn,
5353
createPageFn: CreatePageFn,
5454
customPuppeteer?: typeof puppeteerCore,
@@ -78,8 +78,8 @@ export class ChromeLauncher implements BrowserLauncher {
7878
this.testFiles = testFiles;
7979
}
8080

81-
launchBrowser(options: PuppeteerNodeLaunchOptions = {}) {
82-
const mergedOptions: PuppeteerNodeLaunchOptions = {
81+
launchBrowser(options: LaunchOptions = {}) {
82+
const mergedOptions: LaunchOptions = {
8383
headless: true,
8484
...this.launchOptions,
8585
...options,
@@ -116,7 +116,7 @@ export class ChromeLauncher implements BrowserLauncher {
116116
});
117117
}
118118

119-
async startBrowser(options: PuppeteerNodeLaunchOptions = {}) {
119+
async startBrowser(options: LaunchOptions = {}) {
120120
const browser = await this.launchBrowser(options);
121121
const context = await this.createBrowserContextFn({ config: this.config!, browser });
122122
return { browser, context };

packages/test-runner-chrome/src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import * as puppeteerCore from 'puppeteer-core';
22
import { ChromeLauncher, CreateBrowserContextFn, CreatePageFn } from './ChromeLauncher.js';
3-
import { PuppeteerNodeLaunchOptions } from 'puppeteer-core';
3+
import { LaunchOptions } from 'puppeteer-core';
44

55
export interface ChromeLauncherArgs {
66
puppeteer?: typeof puppeteerCore;
7-
launchOptions?: PuppeteerNodeLaunchOptions;
7+
launchOptions?: LaunchOptions;
88
createBrowserContext?: CreateBrowserContextFn;
99
createPage?: CreatePageFn;
1010
concurrency?: number;

packages/test-runner-puppeteer/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848
"dependencies": {
4949
"@web/test-runner-chrome": "^0.17.0",
5050
"@web/test-runner-core": "^0.13.0",
51-
"puppeteer": "^23.2.0"
51+
"puppeteer": "^24.0.0"
5252
},
5353
"devDependencies": {
5454
"@web/test-runner-mocha": "^0.9.0",
55-
"puppeteer-core": "^23.2.0"
55+
"puppeteer-core": "^24.0.0"
5656
}
5757
}

packages/test-runner-puppeteer/src/puppeteerLauncher.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import * as puppeteer from 'puppeteer';
22
import * as puppeteerCore from 'puppeteer-core';
3-
import { Browser, Page, PuppeteerNodeLaunchOptions } from 'puppeteer-core';
3+
import { Browser, Page, LaunchOptions } from 'puppeteer-core';
44
import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
55
import { chromeLauncher } from '@web/test-runner-chrome';
66

77
export interface PuppeteerLauncherConfig {
8-
launchOptions?: PuppeteerNodeLaunchOptions;
8+
launchOptions?: LaunchOptions;
99
createPage?: (args: { config: TestRunnerCoreConfig; browser: Browser }) => Promise<Page>;
1010
concurrency?: number;
1111
}

0 commit comments

Comments
 (0)