Skip to content

Commit cdaf1c1

Browse files
authored
Merge pull request #2878 from modernweb-dev/chore/migrate-from-deprecated-upload-artifact
chore: migrate from deprecated upload-artifact
2 parents d6d1f26 + 7f7abff commit cdaf1c1

File tree

1 file changed

+11
-44
lines changed

1 file changed

+11
-44
lines changed

.github/workflows/verify-storybook-builder.yml

+11-44
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,23 @@ name: Verify Storybook Builder
33
on: pull_request
44

55
jobs:
6-
verify-storybook-builder-linux:
6+
verify-storybook-builder:
7+
strategy:
8+
fail-fast: false
9+
matrix:
10+
runs-on: [ubuntu-22.04, windows-2022]
11+
runs-on: ${{ matrix.runs-on }}
12+
name: ${{ matrix.runs-on }}
713
timeout-minutes: 60
8-
name: Linux
9-
runs-on: ubuntu-22.04
1014
steps:
1115
- uses: actions/checkout@v4
1216

13-
- name: Setup Node 20
17+
- name: Setup Node 22
1418
uses: actions/setup-node@v4
1519
env:
1620
FORCE_COLOR: 0
1721
with:
18-
node-version: 20
22+
node-version: 22
1923
cache: npm
2024

2125
- name: Install Dependencies
@@ -33,46 +37,9 @@ jobs:
3337
- name: Run tests
3438
run: npm run test:storybook-builder
3539

36-
- uses: actions/upload-artifact@v3
40+
- uses: actions/upload-artifact@v4
3741
if: always()
3842
with:
39-
name: playwright-report
40-
path: packages/storybook-framework-web-components/playwright-report/
41-
retention-days: 30
42-
43-
verify-storybook-builder-windows:
44-
timeout-minutes: 60
45-
name: Windows
46-
runs-on: windows-2022
47-
steps:
48-
- uses: actions/checkout@v4
49-
50-
- name: Setup Node 20
51-
uses: actions/setup-node@v4
52-
env:
53-
FORCE_COLOR: 0
54-
with:
55-
node-version: 20
56-
cache: npm
57-
58-
- name: Install Dependencies
59-
run: npm ci
60-
61-
- name: Build packages
62-
run: npm run build
63-
64-
- name: Symlink built packages binaries (e.g. "wds")
65-
run: npm ci
66-
67-
- name: Install Playwright Browsers
68-
run: npx playwright install --with-deps
69-
70-
- name: Run tests
71-
run: npm run test:storybook-builder
72-
73-
- uses: actions/upload-artifact@v3
74-
if: always()
75-
with:
76-
name: playwright-report
43+
name: playwright-report-${{ matrix.runs-on }}
7744
path: packages/storybook-framework-web-components/playwright-report/
7845
retention-days: 30

0 commit comments

Comments
 (0)