Skip to content

Commit e39b63a

Browse files
author
Sander Aalbers
committed
Update puppeteer to version 22.0.0
1 parent b8d60e1 commit e39b63a

File tree

12 files changed

+1241
-7243
lines changed

12 files changed

+1241
-7243
lines changed

.changeset/few-hounds-shout.md

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@web/test-runner-puppeteer': minor
3+
'@web/test-runner-chrome': minor
4+
'@web/dev-server-hmr': minor
5+
'@web/browser-logs': minor
6+
'@web/dev-server': minor
7+
---
8+
9+
Update puppeteer to 22.0.0

package-lock.json

+1,201-7,231
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/browser-logs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@
5151
},
5252
"devDependencies": {
5353
"@esm-bundle/chai": "^4.1.5",
54-
"puppeteer": "^20.0.0"
54+
"puppeteer": "^22.0.0"
5555
}
5656
}

packages/browser-logs/test/serialize-deserialize.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('serialize deserialize', function () {
1414
let browser: Browser;
1515
let page: Page;
1616
before(async () => {
17-
browser = await puppeteer.launch({ headless: 'new' });
17+
browser = await puppeteer.launch({ headless: true });
1818
page = await browser.newPage();
1919
await page.goto('about:blank');
2020
await page.evaluate(

packages/dev-server-hmr/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@
4444
},
4545
"devDependencies": {
4646
"lit-html": "^2.7.3 || ^3.0.0",
47-
"puppeteer": "^20.0.0"
47+
"puppeteer": "^22.0.0"
4848
}
4949
}

packages/dev-server-hmr/test/browser.test.ts

+20-1
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,29 @@ function trackErrors(page: Page) {
1313
errors.push(error);
1414
});
1515
page.on('console', e => {
16-
if (e.type() === 'error' || e.type() === 'warning') {
16+
if (e.type() === 'error' || e.type() === 'warn') {
1717
errors.push(e.text());
1818
}
1919
});
2020
return errors;
2121
}
2222

23+
async function mockFaviconRequests(page: Page) {
24+
await page.setRequestInterception(true);
25+
page.on('request', request => {
26+
if (request.isInterceptResolutionHandled()) {
27+
return;
28+
}
29+
30+
if (request.url().endsWith('favicon.ico')) {
31+
request.respond({ status: 200 });
32+
return;
33+
}
34+
35+
request.continue();
36+
});
37+
}
38+
2339
describe('browser tests', function () {
2440
this.timeout(5000);
2541
let browser: Browser;
@@ -82,6 +98,7 @@ describe('browser tests', function () {
8298
});
8399
const page = await browser.newPage();
84100
const errors = trackErrors(page);
101+
await mockFaviconRequests(page);
85102

86103
try {
87104
await page.goto(`${host}/foo.html`);
@@ -114,6 +131,7 @@ describe('browser tests', function () {
114131
});
115132
const page = await browser.newPage();
116133
const errors = trackErrors(page);
134+
await mockFaviconRequests(page);
117135

118136
try {
119137
await page.goto(`${host}/foo.html`);
@@ -192,6 +210,7 @@ describe('browser tests', function () {
192210
});
193211
const page = await browser.newPage();
194212
const errors = trackErrors(page);
213+
await mockFaviconRequests(page);
195214

196215
try {
197216
await page.goto(`${host}/foo.html`);

packages/dev-server/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,6 @@
7373
"devDependencies": {
7474
"@types/command-line-usage": "^5.0.1",
7575
"lit-html": "^2.7.3 || ^3.0.0",
76-
"puppeteer": "^20.0.0"
76+
"puppeteer": "^22.0.0"
7777
}
7878
}

packages/test-runner-chrome/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@web/test-runner-coverage-v8": "^0.8.0",
5151
"async-mutex": "0.4.0",
5252
"chrome-launcher": "^0.15.0",
53-
"puppeteer-core": "^20.0.0"
53+
"puppeteer-core": "^22.0.0"
5454
},
5555
"devDependencies": {
5656
"@types/istanbul-reports": "^3.0.0",

packages/test-runner-chrome/src/ChromeLauncher.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export class ChromeLauncher implements BrowserLauncher {
8080

8181
launchBrowser(options: PuppeteerNodeLaunchOptions = {}) {
8282
const mergedOptions: PuppeteerNodeLaunchOptions = {
83-
headless: 'new',
83+
headless: true,
8484
...this.launchOptions,
8585
...options,
8686
};

packages/test-runner-chrome/src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as puppeteerCore from 'puppeteer-core';
22
import { ChromeLauncher, CreateBrowserContextFn, CreatePageFn } from './ChromeLauncher.js';
3-
import { PuppeteerNodeLaunchOptions, devices } from 'puppeteer-core';
3+
import { PuppeteerNodeLaunchOptions, KnownDevices } from 'puppeteer-core';
44

55
export interface ChromeLauncherArgs {
66
puppeteer?: typeof puppeteerCore;
@@ -10,7 +10,7 @@ export interface ChromeLauncherArgs {
1010
concurrency?: number;
1111
}
1212

13-
export { ChromeLauncher, devices, puppeteerCore };
13+
export { ChromeLauncher, KnownDevices, puppeteerCore };
1414

1515
export function chromeLauncher(args: ChromeLauncherArgs = {}) {
1616
const {

packages/test-runner-puppeteer/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848
"dependencies": {
4949
"@web/test-runner-chrome": "^0.15.0",
5050
"@web/test-runner-core": "^0.13.0",
51-
"puppeteer": "^20.0.0"
51+
"puppeteer": "^22.0.0"
5252
},
5353
"devDependencies": {
5454
"@web/test-runner-mocha": "^0.9.0",
55-
"puppeteer-core": "^20.0.0"
55+
"puppeteer-core": "^22.0.0"
5656
}
5757
}
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
export { puppeteerLauncher } from './puppeteerLauncher.js';
2-
export { devices } from 'puppeteer';
2+
export { KnownDevices } from 'puppeteer';

0 commit comments

Comments
 (0)