Fix startup hooks exit code (#175) #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Nov 21, 2025
| this.log.error(error.message); | ||
| if (this.detectImport !== false) { | ||
| process.exit(1); | ||
| } |
Member
There was a problem hiding this comment.
I think the usual style for the surrounding code here is:
if (this.detectImport !== false) process.exit(1);
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Before updating the code, let me comment that the format you suggested aligns with an ESLint rule, and running it, even in the same file (like npx eslint src/app.ts --rule "curly: [2,'multi']") would show many style inconsistences (i.e., besides this one in line 506). Please let me know what you think.
Contributor
Author
|
Could you take another look at my PR when you have a moment? Happy to make any remaining changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
Makes startup hooks (onStart, server:start, etc.) exit with code 1 on error instead of 0.
This preserves test compatibility (detectImport: false) and doesn't affect runtime route errors (which correctly return 500).