Skip to content

Commit dcd4fd5

Browse files
committed
rollback localhost => 127.0.0.1 change for servers
1 parent 4689b47 commit dcd4fd5

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

t/mojo/ioloop_tls.t

+10-10
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ utf8::upgrade $upgraded;
3636
my ($server, $client);
3737
my $promise = Mojo::Promise->new->ioloop($loop);
3838
my $id = $loop->server(
39-
{address => 'localhost', tls => 1} => sub {
39+
{address => '127.0.0.1', tls => 1} => sub {
4040
my ($loop, $stream) = @_;
4141
$stream->write($upgraded => sub { shift->write('321') });
4242
$stream->on(close => sub { $promise->resolve });
@@ -64,7 +64,7 @@ my ($remove, $running, $timeout, $server_err, $server_close, $client_close);
6464
Mojo::IOLoop->remove(Mojo::IOLoop->recurring(0 => sub { $remove++ }));
6565
$promise = Mojo::Promise->new;
6666
$id = Mojo::IOLoop->server(
67-
address => 'localhost',
67+
address => '127.0.0.1',
6868
tls => 1,
6969
tls_ca => 't/mojo/certs/ca.crt',
7070
tls_cert => 't/mojo/certs/server.crt',
@@ -148,7 +148,7 @@ ok $client_err, 'has error';
148148
$loop = Mojo::IOLoop->new;
149149
($server_err, $client_err) = ();
150150
$id = $loop->server(
151-
address => 'localhost',
151+
address => '127.0.0.1',
152152
tls => 1,
153153
tls_ca => 'no cert',
154154
tls_cert => 't/mojo/certs/server.crt',
@@ -176,7 +176,7 @@ ok $client_err, 'has error';
176176
($client, $client_close) = ();
177177
$promise = Mojo::Promise->new;
178178
$id = Mojo::IOLoop->server(
179-
address => 'localhost',
179+
address => '127.0.0.1',
180180
tls => 1,
181181
tls_ca => 't/mojo/certs/ca.crt',
182182
tls_cert => 't/mojo/certs/server.crt',
@@ -231,7 +231,7 @@ ok !$server_err, 'no error';
231231
$loop = Mojo::IOLoop->new;
232232
($server_err, $client_err) = ();
233233
$id = $loop->server(
234-
address => 'localhost',
234+
address => '127.0.0.1',
235235
tls => 1,
236236
tls_cert => 't/mojo/certs/bad.crt',
237237
tls_key => 't/mojo/certs/bad.key',
@@ -256,7 +256,7 @@ ok $client_err, 'has error';
256256
$loop = Mojo::IOLoop->new;
257257
($server_err, $client_err) = ();
258258
$id = $loop->server(
259-
address => 'localhost',
259+
address => '127.0.0.1',
260260
tls => 1,
261261
tls_cert => 't/mojo/certs/bad.crt',
262262
tls_key => 't/mojo/certs/bad.key',
@@ -281,7 +281,7 @@ ok $client_err, 'has error';
281281
$loop = Mojo::IOLoop->new;
282282
($server_err, $client_err) = ();
283283
$id = $loop->server(
284-
address => 'localhost',
284+
address => '127.0.0.1',
285285
tls => 1,
286286
tls_cert => 't/mojo/certs/bad.crt',
287287
tls_key => 't/mojo/certs/bad.key',
@@ -307,7 +307,7 @@ $loop = Mojo::IOLoop->new;
307307
my ($cipher, $version);
308308
($server, $client, $client_err) = ();
309309
$id = $loop->server(
310-
address => 'localhost',
310+
address => '127.0.0.1',
311311
tls => 1,
312312
tls_ca => 't/mojo/certs/ca.crt',
313313
tls_cert => 't/mojo/certs/server.crt',
@@ -347,7 +347,7 @@ is $cipher, $expect, "$expect has been negotiatied";
347347
# Ignore missing client certificate
348348
($server, $client, $client_err) = ();
349349
$id = Mojo::IOLoop->server(
350-
address => 'localhost',
350+
address => '127.0.0.1',
351351
tls => 1,
352352
tls_ca => 't/mojo/certs/ca.crt',
353353
tls_cert => 't/mojo/certs/server.crt',
@@ -372,7 +372,7 @@ subtest 'ALPN' => sub {
372372
plan skip_all => 'ALPN support required!' unless IO::Socket::SSL->can_alpn;
373373
my ($server_proto, $client_proto);
374374
$id = Mojo::IOLoop->server(
375-
address => 'localhost',
375+
address => '127.0.0.1',
376376
tls => 1,
377377
tls_options => {SSL_alpn_protocols => ['foo', 'bar', 'baz']},
378378
sub {

t/mojo/user_agent_tls.t

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ get '/' => {text => 'works!'};
2121
subtest 'Web server with valid certificates' => sub {
2222
my $daemon = Mojo::Server::Daemon->new(app => app, ioloop => Mojo::IOLoop->singleton, silent => 1);
2323
my $listen
24-
= 'https://localhost'
24+
= 'https://127.0.0.1'
2525
. '?cert=t/mojo/certs/server.crt'
2626
. '&key=t/mojo/certs/server.key'
2727
. '&ca=t/mojo/certs/ca.crt&verify=0x03';
@@ -76,7 +76,7 @@ subtest 'Web server with valid certificates' => sub {
7676
subtest 'Web server with valid certificates and no verification' => sub {
7777
my $daemon = Mojo::Server::Daemon->new(app => app, ioloop => Mojo::IOLoop->singleton, silent => 1);
7878
my $listen
79-
= 'https://localhost'
79+
= 'https://127.0.0.1'
8080
. '?cert=t/mojo/certs/server.crt'
8181
. '&key=t/mojo/certs/server.key'
8282
. '&ca=t/mojo/certs/ca.crt'
@@ -100,7 +100,7 @@ subtest 'Web server with valid certificates and no verification' => sub {
100100

101101
subtest 'Client side TLS options' => sub {
102102
my $daemon = Mojo::Server::Daemon->new(app => app, ioloop => Mojo::IOLoop->singleton, silent => 1);
103-
my $listen = 'https://localhost/?version=TLSv1_1';
103+
my $listen = 'https://127.0.0.1/?version=TLSv1_1';
104104
my $port = $daemon->listen([$listen])->start->ports->[0];
105105

106106
subtest '(Not) setting verification mode' => sub {

t/mojo/websocket_proxy_tls.t

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ websocket '/test' => sub {
4747
# Web server with valid certificates
4848
my $daemon = Mojo::Server::Daemon->new(app => app, silent => 1);
4949
my $listen
50-
= 'https://localhost' . '?cert=t/mojo/certs/server.crt' . '&key=t/mojo/certs/server.key' . '&ca=t/mojo/certs/ca.crt';
50+
= 'https://127.0.0.1' . '?cert=t/mojo/certs/server.crt' . '&key=t/mojo/certs/server.key' . '&ca=t/mojo/certs/ca.crt';
5151
my $port = $daemon->listen([$listen])->start->ports->[0];
5252

5353
# Connect proxy server for testing

0 commit comments

Comments
 (0)