refs #1172: Add short introduction to promises #1211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
println doesn't exist in perl, the function is called say. There's a get_p method in Mojo::UserAgent that you can use for the promise-returning function examples. |
|
To much Go lately ;-)
I actually wanted to show how the get could be implemented by using a
promise, to have a useful example of asynchronous operation that takes some
time to complete.
Maybe I should add that get_p does what the example shows.
2018-04-13 23:43 GMT+02:00 Dan Book <[email protected]>:
… println doesn't exist in perl, the function is called say. There's a get_p
method in Mojo::UserAgent that you can use for the promise-returning
function examples.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1211 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACqnmfK8dBbfWZmOEB1mbF5yODkOEhcks5toRwKgaJpZM4TUgNm>
.
|
lib/Mojo/Promise.pm
Outdated
| my $both = Mojo::Promise->all($promise1, $promise2)->then(sub { | ||
| my ($value1, $value2) = @_; | ||
| println "Mojolicous website returns " . $value1; | ||
| println "Perlbrew website returns " . $valuu2; |
There was a problem hiding this comment.
s/valuu2/value2/ in addition to say instead of println as mentioned
|
I think that our basic example should not not reimplement get_p. |
|
Thanks for the feedback!
The basic example was taken from the synopsis, but maybe is not the best
way based on your feedback. I'd like to have something people will
associated with a longer running task (web request, brew beer, background
job, long calculation) and then do the all example to actually put the
promise code to use.
Ideas welcome, on what a basic example could do...
2018-04-14 10:45 GMT+02:00 Marcus Ramberg <[email protected]>:
… I think that our basic example should not not reimplement get_p.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1211 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACqngW1z1n0i7OfvkVvkW-Z37SoOLvfks5tobcngaJpZM4TUgNm>
.
|
|
Looks like this pull request went stale. |
|
Sorry, yes I ran out of time to spare.
But I'm still supporting this PR, but will need some more time (approx 3
weeks)
BR Roland
2018-04-27 10:11 GMT+02:00 Sebastian Riedel <[email protected]>:
… Looks like this pull request went stale.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1211 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACqnm8chBKAxhg3GPt8hRn0UcM3OMyPks5tstLFgaJpZM4TUgNm>
.
|
|
Understood, please open a new pull request when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to improve the documentation of Mojo::Promise with a short introduction into the subject. Only documentation is added, no code changes.
The
printlnin the examples should be replaced with something more useful, but should be ok for discussion for now.Motivation
Improve docs for beginners and newcomers that may find promises and their composability useful.
References
Should close #1172