Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch / update to a static build with Vite for the viewer app #1735

Open
hoeck opened this issue Mar 15, 2025 · 1 comment
Open

Switch / update to a static build with Vite for the viewer app #1735

hoeck opened this issue Mar 15, 2025 · 1 comment

Comments

@hoeck
Copy link
Collaborator

hoeck commented Mar 15, 2025

The current benchmark viewer uses unpkg.com to load its dependencies. That was the easiest solution for me at the time I wrote it (a time where huge webpack configs, commonsj modules and long builds were still the norm 😁 ).

Atm. unpgk.com has long loading times and even timeouts so the benchmark viewer does not work properly, see #1731 (comment)

Whenever I deploy a small app to Github pages these days I'm using a simple static build with Vite using the official github example example. Works without any flaws.

Lets do that for the benchmark viewer too?!

@moltar @DarkGL please 👍 or 👎 or comment so I can start working on a PR.

@DarkGL
Copy link
Collaborator

DarkGL commented Mar 21, 2025

Lets go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants