Fix linter

Author: husniMDB

.github/workflows/pr.yml

@@ -19,7 +19,7 @@ jobs:
       - name: lint
         uses: golangci/[email protected]
         with:
-          version: v1.54.2
+          version: v1.60
 
   tests-on-unix:
     needs: golangci-lint # run after golangci-lint action to not produce duplicated errors

atmcfg/auth.go

@@ -15,7 +15,7 @@
 package atmcfg
 
 import (
-	"crypto/sha1" //nolint:gosec // mongodb scram-sha-1 supports this tho is not recommended
+	"crypto/sha1" // #nosec G101 // #nosec G505 // mongodb scram-sha-1 supports this tho is not recommended
 	"crypto/sha256"
 	"encoding/base64"
 	"errors"

atmcfg/security.go

@@ -16,7 +16,7 @@ package atmcfg
 
 import (
 	"crypto/hmac"
-	"crypto/md5" //nolint:gosec // used as part of the sha1 standard
+	"crypto/md5" // #nosec G101 // #nosec G501 // used as part of the sha1 standard
 	"encoding/base64"
 	"encoding/hex"
 	"fmt"
@@ -165,7 +165,7 @@ func generateSalt(hashConstructor func() hash.Hash) ([]byte, error) {
 }
 
 func md5Hex(s string) (string, error) {
-	h := md5.New() //nolint:gosec // used as part of the sha1 standard
+	h := md5.New() // #nosec G101 // #nosec G401 // used as part of the sha1 standard
 
 	if _, err := h.Write([]byte(s)); err != nil {
 		return "", err

atmcfg/security_test.go

@@ -15,7 +15,7 @@
 package atmcfg
 
 import (
-	"crypto/sha1" //nolint:gosec // used as part of the sha1 standard
+	"crypto/sha1" // #nosec G101 // #nosec G505 // used as part of the sha1 standard
 	"testing"
 
 	"github.com/stretchr/testify/assert"

auth/device_flow_test.go

@@ -173,7 +173,7 @@ func TestConfig_RevokeToken(t *testing.T) {
 	config, mux, teardown := setup()
 	defer teardown()
 
-	mux.HandleFunc("/api/private/unauth/account/device/revoke", func(w http.ResponseWriter, r *http.Request) {
+	mux.HandleFunc("/api/private/unauth/account/device/revoke", func(_ http.ResponseWriter, r *http.Request) {
 		testMethod(t, r)
 	})
 

opsmngr/accesslist_api_keys.go

@@ -20,7 +20,7 @@ import (
 	"net/http"
 )
 
-const accessListAPIKeysPath = "api/public/v1.0/orgs/%s/apiKeys/%s/accessList" //nolint:gosec // This is a path
+const accessListAPIKeysPath = "api/public/v1.0/orgs/%s/apiKeys/%s/accessList" // #nosec G101 // This is a path
 
 // AccessListAPIKeysService is an interface for interfacing with the AccessList API Keys
 // endpoints of the MongoDB Ops Manager API.

opsmngr/accesslist_api_keys_test.go

@@ -24,7 +24,7 @@ import (
 )
 
 const (
-	apiKeyID  = "API-KEY-ID" //nolint:gosec // ID and not an actual key
+	apiKeyID  = "API-KEY-ID" // #nosec G101 // ID and not an actual key
 	ipAddress = "IP-ADDRESS"
 )
 

opsmngr/agents_api_keys.go

@@ -21,7 +21,7 @@ import (
 )
 
 const (
-	agentAPIKeysBasePath = "api/public/v1.0/groups/%s/agentapikeys" //nolint:gosec // This is a path
+	agentAPIKeysBasePath = "api/public/v1.0/groups/%s/agentapikeys" // #nosec G101 // This is a path
 )
 
 // AgentAPIKey defines the structure for an Agent API key.

opsmngr/agents_api_keys_test.go

@@ -22,7 +22,7 @@ import (
 	"github.com/go-test/deep"
 )
 
-const projectID = "5e66185d917b220fbd8bb4d1" //nolint:gosec // not a credential
+const projectID = "5e66185d917b220fbd8bb4d1" // not a credential
 
 func TestAgentsServiceOp_ListAgentAPIKeys(t *testing.T) {
 	client, mux, teardown := setup()

opsmngr/alert_configurations_test.go

@@ -23,7 +23,7 @@ import (
 	"github.com/go-test/deep"
 )
 
-const alertConfigID = "57b76ddc96e8215c017ceafb" //nolint:gosec // not a credential
+const alertConfigID = "57b76ddc96e8215c017ceafb" // #nosec G101 // not a credential
 
 func TestAlertConfiguration_Create(t *testing.T) {
 	client, mux, teardown := setup()