Skip to content

Commit 1ed6e95

Browse files
committed
Add annotations to type-qualify arrays
1 parent 5615fc5 commit 1ed6e95

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

tests/UnifiedSpecTests/UnifiedSpecTest.php

+12-3
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,11 @@
2424
class UnifiedSpecTest extends FunctionalTestCase
2525
{
2626
/**
27-
* Incomplete test groups are listed here. These are checked using a left-
28-
* anchored regex. Note that regex placeholder can't be used.
27+
* Incomplete test groups are listed here. Any data set that starts with a
28+
* string listed in this index will be skipped with the message given as
29+
* value.
30+
*
31+
* @var array<string, string>
2932
*/
3033
private static array $incompleteTestGroups = [
3134
// Many load balancer tests use CMAP events and/or assertNumberConnectionsCheckedOut
@@ -38,6 +41,7 @@ class UnifiedSpecTest extends FunctionalTestCase
3841
'retryable-writes/retryable writes handshake failures' => 'Handshakes are not retried (CDRIVER-4532)',
3942
];
4043

44+
/** @var array<string, string> */
4145
private static array $incompleteTests = [
4246
// Many load balancer tests use CMAP events and/or assertNumberConnectionsCheckedOut
4347
'load-balancers/monitoring events include correct fields: poolClearedEvent events include serviceId' => 'PHPC does not implement CMAP',
@@ -63,12 +67,17 @@ class UnifiedSpecTest extends FunctionalTestCase
6367
* Any tests with duplicate names are skipped here. While test names should
6468
* not be reused in spec tests, this offers a way to skip such tests until
6569
* the name is changed.
70+
*
71+
* @var array<string, string>
6672
*/
6773
private static array $duplicateTests = [];
6874

6975
/**
7076
* Any tests that rely on session pinning (including targetedFailPoint) must
71-
* be skipped since libmongoc does not pin on load-balanced toplogies. */
77+
* be skipped since libmongoc does not pin on load-balanced toplogies.
78+
*
79+
* @var array<string, string>
80+
*/
7281
private static array $incompleteLoadBalancerTests = [
7382
'transactions/mongos-recovery-token: commitTransaction explicit retries include recoveryToken' => 'libmongoc omits recoveryToken for load-balanced topology (CDRIVER-4718)',
7483
'transactions/pin-mongos: multiple commits' => 'libmongoc does not pin for load-balanced topology',

0 commit comments

Comments
 (0)