Assert that the modifiers option is indeed deprecated (#1451)

Author: alcaeus

tests/Operation/FindFunctionalTest.php

@@ -48,7 +48,9 @@ function () use ($modifiers): void {
                     ['modifiers' => $modifiers],
                 );
 
-                $operation->execute($this->getPrimaryServer());
+                $this->assertDeprecated(
+                    fn () => $operation->execute($this->getPrimaryServer()),
+                );
             },
             function (array $event) use ($expectedSort): void {
                 $this->assertEquals($expectedSort, $event['started']->getCommand()->sort ?? null);

tests/TestCase.php

@@ -36,6 +36,7 @@
 use function sprintf;
 use function strtr;
 
+use const E_DEPRECATED;
 use const E_USER_DEPRECATED;
 
 abstract class TestCase extends BaseTestCase
@@ -171,7 +172,7 @@ protected function assertDeprecated(callable $execution): void
 
         set_error_handler(function ($errno, $errstr) use (&$errors): void {
             $errors[] = $errstr;
-        }, E_USER_DEPRECATED);
+        }, E_USER_DEPRECATED | E_DEPRECATED);
 
         try {
             call_user_func($execution);