CLOUDP-303120: fix: Don't panic on deep copy of backup compliance. (#2162)

* fix() Don't panic on deep copy of backup compliance.

The pointers can be nil in which case it will panic. Use the getter to
ensure it's always initialized.

* Add unit test

* Tweak naming/description of test.

Author: segui-mdb

api/v1/atlasbackupcompliancepolicy_types.go

@@ -117,8 +117,8 @@ func NewBCPFromAtlas(in *admin.DataProtectionSettings20231001) *AtlasBackupCompl
 		PITEnabled:              admin.GetOrDefault(in.PitEnabled, false),
 		RestoreWindowDays:       admin.GetOrDefault(in.RestoreWindowDays, 0),
 		OnDemandPolicy: AtlasOnDemandPolicy{
-			RetentionUnit:  in.OnDemandPolicyItem.RetentionUnit,
-			RetentionValue: in.OnDemandPolicyItem.RetentionValue,
+			RetentionUnit:  in.GetOnDemandPolicyItem().RetentionUnit,
+			RetentionValue: in.GetOnDemandPolicyItem().RetentionValue,
 		},
 	}
 

api/v1/atlasbackupcompliancepolicy_types_test.go

@@ -129,3 +129,50 @@ func TestBackupCompliancePolicyFromAtlas(t *testing.T) {
 		assert.True(t, reflect.DeepEqual(*out, want), cmp.Diff(*out, want))
 	})
 }
+
+func TestBackupCompliancePolicyNilOndemandPolicy(t *testing.T) {
+	t.Run("Can convert when OndemandPolicyItem is nil", func(t *testing.T) {
+		in := &admin.DataProtectionSettings20231001{
+			AuthorizedEmail:         "[email protected]",
+			AuthorizedUserFirstName: "James",
+			AuthorizedUserLastName:  "Bond",
+			CopyProtectionEnabled:   pointer.MakePtr(true),
+			EncryptionAtRestEnabled: pointer.MakePtr(false),
+			PitEnabled:              pointer.MakePtr(true),
+			ProjectId:               pointer.MakePtr("testProjectID"),
+			RestoreWindowDays:       pointer.MakePtr(24),
+			ScheduledPolicyItems: &[]admin.BackupComplianceScheduledPolicyItem{
+				{
+					FrequencyType:     "monthly",
+					FrequencyInterval: 2,
+					RetentionUnit:     "months",
+					RetentionValue:    4,
+				},
+			},
+			OnDemandPolicyItem: nil,
+		}
+
+		out := NewBCPFromAtlas(in)
+
+		want := AtlasBackupCompliancePolicySpec{
+			AuthorizedEmail:         "[email protected]",
+			AuthorizedUserFirstName: "James",
+			AuthorizedUserLastName:  "Bond",
+			CopyProtectionEnabled:   true,
+			EncryptionAtRestEnabled: false,
+			PITEnabled:              true,
+			RestoreWindowDays:       24,
+			ScheduledPolicyItems: []AtlasBackupPolicyItem{
+				{
+					FrequencyType:     "monthly",
+					FrequencyInterval: 2,
+					RetentionUnit:     "months",
+					RetentionValue:    4,
+				},
+			},
+			OnDemandPolicy: AtlasOnDemandPolicy{},
+		}
+
+		assert.True(t, reflect.DeepEqual(*out, want), cmp.Diff(*out, want))
+	})
+}