Skip to content

Commit adb5b2b

Browse files
committed
fix tests
1 parent b2c8021 commit adb5b2b

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

backend/__tests__/__integration__/dal/leaderboards.isolated.spec.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,8 @@ describe("LeaderboardsDal", () => {
290290
"60",
291291
"english",
292292
1,
293-
2
293+
2,
294+
true
294295
)) as LeaderboardsDal.DBLeaderboardEntry[];
295296

296297
//THEN
@@ -317,6 +318,7 @@ describe("LeaderboardsDal", () => {
317318
"english",
318319
0,
319320
50,
321+
false,
320322
[rank1.uid, rank4.uid]
321323
)) as LeaderboardsDal.DBLeaderboardEntry[];
322324

@@ -338,11 +340,15 @@ describe("LeaderboardsDal", () => {
338340

339341
//WHEN
340342

341-
const result = (await LeaderboardsDal.get("time", "60", "english", 1, 2, [
342-
rank1.uid,
343-
rank2.uid,
344-
rank4.uid,
345-
])) as LeaderboardsDal.DBLeaderboardEntry[];
343+
const result = (await LeaderboardsDal.get(
344+
"time",
345+
"60",
346+
"english",
347+
1,
348+
2,
349+
false,
350+
[rank1.uid, rank2.uid, rank4.uid]
351+
)) as LeaderboardsDal.DBLeaderboardEntry[];
346352

347353
//THEN
348354
const lb = result.map((it) => _.omit(it, ["_id"]));

backend/__tests__/api/controllers/leaderboard.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,23 +105,22 @@ describe("Loaderboard Controller", () => {
105105
"english",
106106
0,
107107
50,
108-
false
109-
108+
false,
109+
undefined
110110
);
111111

112112
expect(getLeaderboardCountMock).toHaveBeenCalledWith(
113113
"time",
114114
"60",
115115
"english",
116116
undefined
117-
118117
);
119118
});
120119

121120
it("should get for english time 60 with page", async () => {
122121
//GIVEN
123122
getLeaderboardMock.mockResolvedValue([]);
124-
getLeaderboardCountMock.mockResolvedValue(0);
123+
getLeaderboardCountMock.mockResolvedValue(42);
125124
const page = 0;
126125
const pageSize = 25;
127126

@@ -154,7 +153,8 @@ describe("Loaderboard Controller", () => {
154153
"english",
155154
page,
156155
pageSize,
157-
false
156+
false,
157+
undefined
158158
);
159159
});
160160

@@ -187,14 +187,14 @@ describe("Loaderboard Controller", () => {
187187
"english",
188188
0,
189189
50,
190+
false,
190191
["uidOne", "uidTwo"]
191192
);
192193
expect(getLeaderboardCountMock).toHaveBeenCalledWith(
193194
"time",
194195
"60",
195196
"english",
196197
["uidOne", "uidTwo"]
197-
>>>>>>> 7e96c814c (feat(leaderboard): add friends leaderboards (@fehmer))
198198
);
199199
});
200200

0 commit comments

Comments
 (0)