Fixed gallery view after all pictures taken (compliant or not) (#933)

Author: dlymonkai

packages/inspection-capture-web/src/PhotoCapture/PhotoCapture.tsx

@@ -201,8 +201,6 @@ export function PhotoCapture({
     tasksBySight,
     complianceOptions,
     setIsInitialInspectionFetched,
-    startTasksOnComplete,
-    onComplete,
   });
   const { currentTutorialStep, goToNextTutorialStep, closeTutorial } = usePhotoCaptureTutorial({
     enableTutorial,

packages/inspection-capture-web/src/PhotoCapture/PhotoCaptureHUD/PhotoCaptureHUDElementsSight/PhotoCaptureHUDElementsSight.tsx

@@ -40,7 +40,10 @@ export function PhotoCaptureHUDElementsSight({
       {!tutorialStep && (
         <div style={style.elementsContainer}>
           <div style={style.top}>
-            {enableSightTutorial !== PhotoCaptureSightTutorialOption.DISABLED && (
+            {[
+              PhotoCaptureSightTutorialOption.CLASSIC,
+              PhotoCaptureSightTutorialOption.MODERN,
+            ].includes(enableSightTutorial as PhotoCaptureSightTutorialOption) && (
               <SightTutorialButton toggleSightTutorial={toggleSightTutorial} />
             )}
             <SightGuideline

packages/inspection-capture-web/src/PhotoCapture/hooks/usePhotoCaptureSightState.ts

@@ -22,7 +22,6 @@ import {
   TaskName,
   ImageStatus,
   ProgressStatus,
-  PhotoCaptureAppConfig,
 } from '@monkvision/types';
 import { sights } from '@monkvision/sights';
 import { useAnalytics } from '@monkvision/analytics';
@@ -81,8 +80,7 @@ export interface PhotoCaptureSightState {
 /**
  * Parameters of the usePhotoCaptureSightState hook.
  */
-export interface PhotoCaptureSightsParams
-  extends Pick<PhotoCaptureAppConfig, 'startTasksOnComplete'> {
+export interface PhotoCaptureSightsParams {
   /**
    * The inspection ID.
    */
@@ -116,10 +114,6 @@ export interface PhotoCaptureSightsParams
    * sight will be used.
    */
   tasksBySight?: Record<string, TaskName[]>;
-  /**
-   * Callback called when inspection capture is complete.
-   */
-  onComplete?: () => void;
 }
 
 function getCaptureTasks(
@@ -215,8 +209,6 @@ export function usePhotoCaptureSightState({
   tasksBySight,
   setIsInitialInspectionFetched,
   complianceOptions,
-  startTasksOnComplete,
-  onComplete,
 }: PhotoCaptureSightsParams): PhotoCaptureSightState {
   if (captureSights.length === 0) {
     throw new Error('Empty sight list given to the Monk PhotoCapture component.');
@@ -331,7 +323,7 @@ export function usePhotoCaptureSightState({
     });
     if (nextSight) {
       setSelectedSight(nextSight);
-    } else if (!startTasksOnComplete || !onComplete) {
+    } else {
       onLastSightTaken();
     }
   }, [sightsTaken, selectedSight, captureSights, onLastSightTaken]);

packages/inspection-capture-web/test/PhotoCapture/PhotoCapture.test.tsx

@@ -229,8 +229,6 @@ describe('PhotoCapture component', () => {
       loading,
       onLastSightTaken: expect.any(Function),
       tasksBySight: props.tasksBySight,
-      startTasksOnComplete: props.startTasksOnComplete,
-      onComplete: props.onComplete,
       complianceOptions: {
         enableCompliance: props.enableCompliance,
         enableCompliancePerSight: props.enableCompliancePerSight,

packages/inspection-capture-web/test/PhotoCapture/hooks/usePhotoCaptureSightState.test.ts

@@ -48,8 +48,6 @@ function createParams(): PhotoCaptureSightsParams {
       useLiveCompliance: true,
     },
     setIsInitialInspectionFetched: jest.fn(),
-    onComplete: jest.fn(),
-    startTasksOnComplete: false,
   };
 }