Extend finding of functions to also get overloads

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/AST/ASTContext.cs

@@ -92,8 +92,7 @@ public Class FindCompleteClass(string name, bool ignoreCase = false)
         /// Finds an existing function in the library modules.
         public IEnumerable<Function> FindFunction(string name)
         {
-            return TranslationUnits.Select(module => module.FindFunction(name))
-                .Where(type => type != null);
+            return TranslationUnits.SelectMany(module => module.FindFunction(name));
         }
 
         /// Finds an existing typedef in the library modules.

src/AST/Namespace.cs

@@ -160,33 +160,33 @@ public Enumeration FindEnum(IntPtr ptr)
             return Enums.FirstOrDefault(f => f.OriginalPtr == ptr);
         }
 
-        public Function FindFunction(string name, bool createDecl = false)
+        public IEnumerable<Function> FindFunction(string name, bool createDecl = false)
         {
             if (string.IsNullOrEmpty(name)) 
-                return null;
+                return Enumerable.Empty<Function>();
 
             var entries = name.Split(new string[] { "::" },
                 StringSplitOptions.RemoveEmptyEntries).ToList();
 
             if (entries.Count <= 1)
             {
-                var function = Functions.FirstOrDefault(e => e.Name.Equals(name));
+                var functions = Functions.Where(e => e.Name.Equals(name));
 
-                if (function == null && createDecl)
+                if (!functions.Any() && createDecl)
                 {
-                    function = new Function() { Name = name, Namespace = this };
+                    var function = new Function() { Name = name, Namespace = this };
                     Declarations.Add(function);
                 }
 
-                return function;
+                return functions;
             }
 
-            var funcName = entries[entries.Count - 1];
+            var funcName = entries[^1];
             var namespaces = entries.Take(entries.Count - 1);
 
             var @namespace = FindNamespace(namespaces);
             if (@namespace == null)
-                return null;
+                return Enumerable.Empty<Function>();
 
             return @namespace.FindFunction(funcName, createDecl);
         }
@@ -201,14 +201,12 @@ public Function FindFunctionByUSR(string usr)
 
         Class CreateClass(string name, bool isComplete)
         {
-            var  @class = new Class
+            return new Class
             {
                 Name = name,
                 Namespace = this,
                 IsIncomplete = !isComplete
             };
-
-            return @class;
         }
 
         public Class FindClass(string name,
@@ -316,7 +314,7 @@ public TypedefNameDecl FindTypedef(string name, bool createDecl = false)
         public T FindType<T>(string name) where T : Declaration
         {
             var type = FindEnum(name)
-                ?? FindFunction(name)
+                ?? FindFunction(name).FirstOrDefault()
                 ?? (Declaration)FindClass(name)
                 ?? FindTypedef(name);
 

src/Generator/Library.cs

@@ -533,7 +533,7 @@ public static void CopyClassFields(this ASTContext context, string source,
         public static IEnumerable<Function> FindFunction(this ASTContext context, string name)
         {
             return context.TranslationUnits
-                .Select(module => module.FindFunction(name))
+                .SelectMany(module => module.FindFunction(name))
                 .Where(function => function != null);
         }