Skip to content
This repository was archived by the owner on Oct 4, 2021. It is now read-only.

Commit 1e2564c

Browse files
Rodrigo Moyarodrmoya
Rodrigo Moya
authored andcommitted
[AspNetCore] Don't create browser-based execution targets for Worker services
With the enabling of launchSettings.json support for Worker services, we added support, by mistake, to run it on the user's installed browsers, which is wrong, as Worker services are just console applications. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050466
1 parent b9b2dc8 commit 1e2564c

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreProjectExtension.cs

+20-16
Original file line numberDiff line numberDiff line change
@@ -178,26 +178,30 @@ protected override Task OnExecute (
178178

179179
protected override IEnumerable<ExecutionTarget> OnGetExecutionTargets (OperationContext ctx, ConfigurationSelector configuration, SolutionItemRunConfiguration runConfig)
180180
{
181-
var result = new ExecutionTargetGroup (GettextCatalog.GetString ("Browser"), "MonoDevelop.AspNetCore.BrowserExecutionTargets");
182-
foreach (var browser in IdeServices.DesktopService.GetApplications ("https://localhost", Ide.Desktop.DesktopApplicationRole.Viewer)) {
183-
if (browser.IsDefault) {
184-
if (Project.HasMultipleTargetFrameworks) {
185-
result.InsertRange (0, GetMultipleTargetFrameworkExecutionTargets (browser));
181+
if (IsWeb) {
182+
var result = new ExecutionTargetGroup (GettextCatalog.GetString ("Browser"), "MonoDevelop.AspNetCore.BrowserExecutionTargets");
183+
foreach (var browser in IdeServices.DesktopService.GetApplications ("https://localhost", Ide.Desktop.DesktopApplicationRole.Viewer)) {
184+
if (browser.IsDefault) {
185+
if (Project.HasMultipleTargetFrameworks) {
186+
result.InsertRange (0, GetMultipleTargetFrameworkExecutionTargets (browser));
187+
} else {
188+
result.Insert (0, new AspNetCoreExecutionTarget (browser));
189+
}
186190
} else {
187-
result.Insert (0, new AspNetCoreExecutionTarget (browser));
188-
}
189-
} else {
190-
if (Project.HasMultipleTargetFrameworks) {
191-
result.AddRange (GetMultipleTargetFrameworkExecutionTargets (browser));
192-
} else {
193-
result.Add (new AspNetCoreExecutionTarget (browser));
191+
if (Project.HasMultipleTargetFrameworks) {
192+
result.AddRange (GetMultipleTargetFrameworkExecutionTargets (browser));
193+
} else {
194+
result.Add (new AspNetCoreExecutionTarget (browser));
195+
}
194196
}
195197
}
196-
}
197198

198-
return result.Count > 0
199-
? new ExecutionTarget [] { result }
200-
: base.OnGetExecutionTargets (ctx, configuration, runConfig);
199+
return result.Count > 0
200+
? new ExecutionTarget [] { result }
201+
: base.OnGetExecutionTargets (ctx, configuration, runConfig);
202+
} else {
203+
return base.OnGetExecutionTargets (ctx, configuration, runConfig);
204+
}
201205
}
202206

203207
IEnumerable<ExecutionTarget> GetMultipleTargetFrameworkExecutionTargets (DesktopApplication browser)

0 commit comments

Comments
 (0)