Merge pull request #313 from kabalin/nvm-fix

kabalin · web-flow · commit 1b44ae050c38 · 2024-08-23T12:08:13.000+01:00
Fix nvm loading issue.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -9,6 +9,9 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com).
 
 ## [Unreleased]
+### Changed
+- Fixed nvm loading issue caused by upstream regression.
+
 ## [4.5.3] - 2024-07-05
 ### Added
 - Support for version 4.4 of the app, that uses new defaults and Chrome (Selenium 4) version.
diff --git a/src/Installer/VendorInstaller.php b/src/Installer/VendorInstaller.php
@@ -120,7 +120,7 @@ public function installNode(): void
         }
 
         $nvmDir  = getenv('NVM_DIR');
-        $cmd     = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
+        $cmd     = ". $nvmDir/nvm.sh; nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
 
         $process = $this->execute->passThroughProcess(
             Process::fromShellCommandline($cmd, $this->moodle->directory, null, null, null)

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function installNode(): void`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`$nvmDir = getenv('NVM_DIR');`
`123`		`- $cmd = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";`
	`123`	`+ $cmd = ". $nvmDir/nvm.sh; nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";`
`124`	`124`
`125`	`125`	`$process = $this->execute->passThroughProcess(`
`126`	`126`	`Process::fromShellCommandline($cmd, $this->moodle->directory, null, null, null)`