Skip to content

Commit 463ddc1

Browse files
Javier Contreras Tenoriomoz-wptsync-bot
authored andcommitted
Bug 1999319 [wpt PR 55961] - [gap-decorations] Fix multicol CrossGap's EdgeIntersection state, a=testonly
Automatic update from web-platform-tests [gap-decorations] Fix multicol CrossGap's EdgeIntersection state Due to some recent changes to the `outset` behavior, we have to now differentiate between `edge` intersections and `interior` intersections which wasn't previously needed for multicol (they were all treated as edge). w3c/csswg-drafts#12603 This CL fixes this and marks the relevant tests as passing, although a change was needed to one of them that was wrong (row gaps/ main gaps in multicol always span from one end of the content to the other, since there are no intersections between row gaps and column gaps). This CL also modifies an existing unittest that with recent changes done to the `column-wrap` feature, it got all twisted and didn't make as much sense anymore (visually). It still tests the same scenario as before (having a spanner and a row gap in the same multicol). It must be noted that depending on some ongoing discussions, we might still want all multicol CrossGaps to be treated as edge intersections, but that is TBD. w3c/csswg-drafts#12784 Bug: 357648037 Change-Id: I95b452ffb89b4117f4855ae9cc1a1c9b00dfdc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7125761 Reviewed-by: Alison Maher <[email protected]> Commit-Queue: Javier Contreras <[email protected]> Cr-Commit-Position: refs/heads/main@{#1542604} -- wpt-commits: 295c5cef574c15782af987a0efbba0f03872f049 wpt-pr: 55961
1 parent a6e0194 commit 463ddc1

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

testing/web-platform/tests/css/css-gaps/multicol/multicol-gap-decorations-023-ref.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
height: 10px;
2727
top: 62px;
2828
background: gold;
29+
width: 203px;
2930
}
3031
.row {
3132
background: gold;
@@ -47,9 +48,7 @@
4748
<div class="items"></div>
4849
<div class="items"></div>
4950
</div>
50-
<div class="row-gap" style="left:0px; width: 61px;"></div>
51-
<div class="row-gap" style="left:72px; width: 59px;"></div>
52-
<div class="row-gap" style="left:142px; width: 62px;"></div>
51+
<div class="row-gap" style="left:0px;"></div>
5352
<div class="column-gap" style="left:62px;"></div>
5453
<div class="column-gap" style="left:132px;"></div>
5554
<div class="column-gap" style="left:62px; top:72px; height: 60px"></div>

testing/web-platform/tests/css/css-gaps/multicol/multicol-gap-decorations-023.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@
2929
column-rule-interior-start-outset: 0;
3030
column-rule-interior-end-outset: 8px;
3131
row-rule-break: intersection;
32-
row-rule-interior-start-outset: 0;
33-
row-rule-interior-end-outset: -1px;
3432
row-rule-edge-start-outset: 2px;
35-
row-rule-edge-end-outset: 2px;
33+
row-rule-edge-end-outset: 1px;
3634
gap-rule-overlap: column-over-row;
3735
}
3836
p {

0 commit comments

Comments
 (0)