Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for consumers #13

Open
garvankeeley opened this issue Apr 30, 2019 · 6 comments
Open

Add documentation for consumers #13

garvankeeley opened this issue Apr 30, 2019 · 6 comments

Comments

@garvankeeley
Copy link
Contributor

No description provided.

@garvankeeley garvankeeley changed the title A documentation for consumers Add documentation for consumers Apr 30, 2019
@chrmod
Copy link

chrmod commented Apr 1, 2020

Hi @garvankeeley, we at cliqz.com are running a Firefox for iOS fork https://github.com/cliqz/user-agent-ios
We find it very hard to use MappaMundi without having a top level overview on how it works or what it is suppose to do.
Any documention would help a lot. Thanks in advance!

@isabelrios
Copy link
Contributor

Hi @chrmod sorry for jumping in but I may be able to help you with that since I work on the test automation for Firefox-iOS and I've been using MappaMundi for some time now.
Let me share this link where we added information about our screenGraph, sorry since there might be some out of date info, but in general I think it may be useful:
https://github.com/mozilla-mobile/firefox-ios/wiki/FxScreenGraph-and-XCUITest

Feel free to ask as many questions as you have, I will try to help :)

@chrmod
Copy link

chrmod commented Apr 2, 2020

@isabelrios thanks for the link, it helped a lot!

There are couple things that are not covered:

  • MMScreenGraph#addScreenAction
  • MMScreenStateBuilder#noop

With new knownledge we were able to fix couple tests we broke due to UX changes of our browser. ghostery/user-agent-ios#875

How about you commit this documentation as MappaMundi README?

@isabelrios
Copy link
Contributor

isabelrios commented Apr 2, 2020

Hey @chrmod, let me add some examples for those questions:
MMScreenGraph#addScreenAction
MMScreenStateBuilder#noop IIRC, This was to have an state in which you don't go to any other screen, like no operation there

Hope that helps :)
Yeah I will try to add this info in a README.
BTW, I saw you are using the Graph with the same name, FxScreenGraph, it may be a good idea to kind of call your graph after your app. We are using it also in another iOS app, and it was renamed as the app name Nothing important, just a comment ;)

@chrmod
Copy link

chrmod commented Apr 3, 2020

Hi @isabelrios once again thank you for your help, it is much appriciated :-)

Would it be possible to chat about MappaMundi over matrix or something? (my id: @chrmod:matrix.org). We have some ideas to use MappaMundi for other tasks like:

  • automated screenshot generation
  • measuring UX regressions
  • drawing app screen graph

Maybe we could collaborate on those topics if you find them interesting.

@isabelrios
Copy link
Contributor

Sure @chrmod sounds good to me. I will add you.
We already use it for screenshots test, in case you want to take a look here

And at some point I think we were generating also the app screen graph. So it would be good to do that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants