tidy various

Author: StuartIanNaylor

zram-config

@@ -185,22 +185,6 @@ case "$1" in
 		rm -f ${ZSHARE}/zram-device-list >>${ZLOG}
 		file=/etc/ztab
 		ZTAB_EMPTY=true
-		#Only 1 log can exist also make first as then last removed
-		line=$(grep ^log $file | head -n 1)
-		if [ ! -z "$line" ]
-		then
-			set -- $line
-			echo "ztab create $1 $2 $3 $4 $5 $6 $7 $8 $9" >>${ZLOG}
-			ZTAB_EMPTY=false
-			ZTYPE=$1
-			ALG=$2
-			MEM_SIZE=$3
-			DISK_SIZE=$4
-			TARGET_DIR=$5
-			BIND_DIR=$6
-			OLDLOG_DIR=$7
-			createZlog
-		fi
 		while read -r line; do
 			case "$line" in
 				"#"*)
@@ -213,10 +197,6 @@ case "$1" in
 					continue
 					;;
 
-				log*)
-					# Skip empty line
-					continue
-					;;
 				*)
 					set -- $line
 					echo "ztab create $1 $2 $3 $4 $5 $6 $7 $8 $9" >>${ZLOG}
@@ -237,12 +217,19 @@ case "$1" in
 							BIND_DIR=$6
 							createZdir
 							;;
+						log)
+							TARGET_DIR=$5
+							BIND_DIR=$6
+							OLDLOG_DIR=$7
+							createZlog
+							;;
 					esac
 					;;
 			esac
 		done < "$file"
 		if [ "$ZTAB_EMPTY" = true ] ; then
 			echo '/etc/ztab is empty and needs to be configured' >>${ZLOG}
+			exit 1
 		fi
 		;;
 	stop)
@@ -260,92 +247,38 @@ case "$1" in
 					# Skip empty line
 					continue
 					;;
-					
-				log*)
-					# Skip empty line
-					continue
-					;;
-
 				*)
 					set -- $line
 					echo "ztab remove $1 $2 $3 $4" >>${ZLOG}
-
 					case "$1" in
 						swap)
+							ZTYPE=$1
 							ZRAM_DEV=$2
 							LABEL=$3
 							removeZswap
 							;;
 						dir)
+							ZTYPE=$1
 							ZRAM_DEV=$2
 							TARGET_DIR=$3
 							BIND_DIR=$4
 							removeZdir
 							;;
+						log)
+							ZTYPE=$1
+							ZRAM_DEV=$2
+							TARGET_DIR=$3
+							BIND_DIR=$4
+							removeZlog
+							;;
 					esac
 					;;
 			esac
 		done < "$file"
-		#Only 1 log can exist also make first as then last removed
-		file=${ZSHARE}/zram-device-list.rev
-		line=$(grep ^log $file | head -n 1)
-		if [ ! -z "$line" ]
-		then
-			set -- $line
-			echo "ztab remove $1 $2 $3 $4 $5 $6 $7 $8 $9" >>${ZLOG}
-			ZTAB_EMPTY=false
-			ZRAM_DEV=$2
-			TARGET_DIR=$3
-			BIND_DIR=$4
-			removeZlog
-		fi
 		rm -v ${ZSHARE}/zram-device-list.rev >>${ZLOG}
 		;;
-	write)
-		echo "zram-config write $(date +%Y-%m-%d-%H:%M:%S)" >>${ZLOG}
-		file=/etc/ztab
-		#Only 1 log can exist also make first as then last removed
-		line=$(grep ^log $file | head -n 1)
-		if [ ! -z "$line" ]
-		then
-			set -- $line
-			echo "ztab write $1 $2 $3 $4 $5 $6 $7 $8 $9" >>${ZLOG}
-			ZTAB_EMPTY=false
-			ALG=$2
-			MEM_SIZE=$3
-			DISK_SIZE=$4
-			TARGET_DIR=$5
-			BIND_DIR=$6
-			OLDLOG_DIR=$7
-			syncToDisk
-		fi
-		while read -r line; do
-			case "$line" in
-				"#"*)
-					# Skip comment line
-					continue
-					;;
-
-				"")
-					# Skip empty line
-					continue
-					;;
-
-				*)
-					set -- $line
-					ALG=$2
-					MEM_SIZE=$3
-					DISK_SIZE=$4
-					case "$1" in
-						dir)
-							echo "ztab write $1 $2 $3 $4 $5 $6 $7 $8 $9" >>${ZLOG}
-							TARGET_DIR=$5
-							BIND_DIR=$6
-							syncToDisk
-							;;
-					esac
-					;;
-			esac
-		done < "$file"
-		;;	
+	*)
+		echo "Usage: zram-config {start|stop}" >&2
+		exit 1
+		;;
 esac