Skip to content

Commit 8784b13

Browse files
committed
fix for PR review change error
1 parent 63d9479 commit 8784b13

File tree

1 file changed

+8
-9
lines changed
  • client/packages/common/src/ui/components/navigation/Tabs

1 file changed

+8
-9
lines changed

client/packages/common/src/ui/components/navigation/Tabs/DetailTabs.tsx

+8-9
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ interface DetailTabsProps {
2626
requiresConfirmation?: (tab: string) => boolean;
2727
}
2828

29-
const handleResize = debounce(
30-
() => window.dispatchEvent(new Event('resize')),
31-
100
32-
);
33-
3429
export const DetailTabs: FC<DetailTabsProps> = ({
3530
tabs,
3631
requiresConfirmation = () => false,
@@ -54,10 +49,10 @@ export const DetailTabs: FC<DetailTabsProps> = ({
5449
const { isOpen: detailPanelOpen } = useDetailPanelStore();
5550
const { isOpen: drawerOpen } = useDrawer();
5651
const { showConfirmation } = useConfirmOnLeaving(false);
57-
58-
useEffect(() => {
59-
handleResize();
60-
}, [detailPanelOpen, drawerOpen]);
52+
const handleResize = useCallback(
53+
() => debounce(() => window.dispatchEvent(new Event('resize')), 100),
54+
[]
55+
);
6156

6257
const [tabQueryParams, setTabQueryParams] = useState<
6358
Record<string, UrlQueryObject>
@@ -85,6 +80,10 @@ export const DetailTabs: FC<DetailTabsProps> = ({
8580
}
8681
};
8782

83+
useEffect(() => {
84+
handleResize();
85+
}, [detailPanelOpen, drawerOpen, handleResize]);
86+
8887
useEffect(() => {
8988
const tab = urlQuery['tab'] as string | undefined;
9089
if (isValidTab(tab)) {

0 commit comments

Comments
 (0)