Merge pull request #5734 from msupply-foundation/5733-samsung-negative-inputs

5733 remove numeric input mode for number inputs

Author: lache-melvin

client/packages/common/src/ui/components/inputs/TextInput/NumericTextInput.tsx

@@ -195,6 +195,7 @@ export const NumericTextInput = React.forwardRef<
       noFormatting = false,
       fullWidth,
       endAdornment,
+      inputMode,
       ...props
     },
     ref
@@ -273,7 +274,7 @@ export const NumericTextInput = React.forwardRef<
           },
           ...sx,
         }}
-        inputMode="numeric"
+        inputMode={inputMode ?? 'numeric'}
         InputProps={{
           endAdornment: endAdornment ? (
             <InputAdornment position="end" sx={{ paddingBottom: '2px' }}>

client/packages/requisitions/src/RnRForms/DetailView/RnRFormLine.tsx

@@ -360,6 +360,11 @@ const RnRNumberCell = ({
           max={max}
           allowNegative={allowNegative}
           defaultValue={0}
+          // NOTE: not setting input mode to text, because on Samsung tablets,
+          // the numeric keyboard doesn't allow entering negative numbers!
+          // Only needed for the negative columns, but better feel to have a consistent
+          // keyboard as you click through the whole R&R form
+          inputMode="text"
         />
       </Tooltip>
     </td>