Skip to content

[select] Fix remembered typeahead value when reset while closed #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atomiks wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[select] Fix remembered typeahead value when reset while closed #3381

atomiks wants to merge 2 commits into from

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 1, 2025 •
edited
Loading

@atomiks atomiks added component: select Changes related to the select component. type: bug It doesn't behave as expected. labels Dec 1, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025 •
edited
Loading

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3381

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3381

commit: d99decb

@mui-bot
Copy link

mui-bot commented Dec 1, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+99B(+0.02%) 🔺+36B(+0.03%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 1, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit d99decb
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/692eb05eca4de30008033240
😎 Deploy Preview https://deploy-preview-3381--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the fix/select-remembered-typeahead branch from f7f0230 to e30d1be Compare December 1, 2025 09:43
@atomiks atomiks force-pushed the fix/select-remembered-typeahead branch from e30d1be to 84ff090 Compare December 1, 2025 10:01
@atomiks atomiks force-pushed the fix/select-remembered-typeahead branch from 073d9fa to d99decb Compare December 2, 2025 09:24
@atomiks atomiks marked this pull request as ready for review December 3, 2025 08:48
@michaldudak
Copy link
Member

michaldudak commented Dec 3, 2025

It's still unreliable - sometimes it resets, sometimes it doesn't.
In this example, it doesn't reset when I pressed Shift+Tab to focus the Select again, but a while ago this worked, and click-away didn't.

Screen.Recording.2025-12-03.at.10.08.59.mov

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: select Changes related to the select component. PR: out-of-date The pull request has merge conflicts and can't be merged. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[select] Typeahead remembers the previous item after resetting the selected value

3 participants

@atomiks @mui-bot @michaldudak