[DateRangeCalendar] Do not update the previewed day when hover a day and the value is empty #16819
Conversation
…and the value is empty
flaviendelangle
added
the
component: pickers
flaviendelangle
added
needs cherry-pick
| (event: React.MouseEvent<HTMLDivElement>, newPreviewRequest: PickerValidDate) => { | ||
| if (!isWithinRange(utils, newPreviewRequest, valueDayRange)) { | ||
| setRangePreviewDay(newPreviewRequest); | ||
| (event: React.MouseEvent<HTMLDivElement>, newRangePreviewDay: PickerValidDate) => { |
There was a problem hiding this comment.
There is one scenario where this does not work: if you hover a day while value === [null, null], you don't move your mouse and you have an update of the value (from some server update).
Before this PR, the preview range would be applied.
Now it would not.
I think the trade-off is fine here, especially given than before this PR is would break already if you hovered inside the range and the value updates (since we do setRangePreviewDay(null) on line 476).
I could store the hovered date in a ref if it's not causing any preview and check when the value change, but tbh it feels like wasted complexity.
|
Deploy preview: https://deploy-preview-16819--material-ui-x.netlify.app/ |
|
Cherry-pick PRs will be created targeting branches: v7.x |
…and the value is empty (#16819)
|
If you can create a dedicated issue 🙏 |
Fixes #16815
TODO: Apply the same logic to #16069 if needed