Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid Header Filters don't display restored values (Only Text Type) #16826

Open
daffron opened this issue Mar 5, 2025 · 2 comments · May be fixed by #16855
Open

Datagrid Header Filters don't display restored values (Only Text Type) #16826

daffron opened this issue Mar 5, 2025 · 2 comments · May be fixed by #16855
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering on header Related to the header filtering (Pro) feature support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@daffron
Copy link

daffron commented Mar 5, 2025

Steps to reproduce

Steps:

  1. Open this link to live example: https://codesandbox.io/embed/xrpvsl?module=/src/Demo.tsx&fontsize=12

  2. Add the headerFilters prop to enable them

  3. Create a text filter under "Trader Name" & another boolean filter

  4. Save the current view

  5. Clear the current filters

  6. Restore the view by clicking on the "Custom View" option

  7. Observe that the "Trader Name" field is still empty

  8. Observe that the boolean field has been populated correctly

  9. Observe that after clicking the filter icon to open the filter box, the text field has been applied to the modal okay, just is not replicated in the header filters.

Current behavior

Header filters are not kept in sync with filterModel on restore

Expected behavior

Header filters should be kept in sync with filter model

Context

No response

Your environment

N/A - Was able to replicate on the sandbox linked from the docs as above

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: header filters state restore

Order ID: 87194

@daffron daffron added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 5, 2025
@github-actions github-actions bot added component: data grid This is the name of the generic UI component, not the React module! support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/ labels Mar 5, 2025
@MBilalShafi MBilalShafi added feature: Filtering on header Related to the header filtering (Pro) feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 5, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Mar 5, 2025
@MBilalShafi MBilalShafi moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Mar 5, 2025
@michelengelen
Copy link
Member

@daffron this is being handled already! Thanks @MBilalShafi 👍🏼

@daffron
Copy link
Author

daffron commented Mar 6, 2025

@daffron this is being handled already! Thanks @MBilalShafi 👍🏼

Awesome thank you!

@MBilalShafi MBilalShafi self-assigned this Mar 7, 2025
@MBilalShafi MBilalShafi linked a pull request Mar 7, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering on header Related to the header filtering (Pro) feature support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/
Projects
Status: 🔖 Ready
Development

Successfully merging a pull request may close this issue.

3 participants