Add timestamp display option for chatbox/console#4568
Add timestamp display option for chatbox/console#4568Xenius97 wants to merge 2 commits intomultitheftauto:masterfrom
Conversation
Xenius97
changed the title
|
Loved it. |
|
It'd be nice if chat and console were separate options, I'd like to have timestamp shown in console but not chat, I don't want to clutter chat too much but console is a bigger window |
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
thanks for the pull request, here's some feedback
There was a problem hiding this comment.
Toggling the setting should show/hide the time in the chat and the console.
The current implementation conditionally modifies the chat string to include the time.
Instead I suggest you save the timestamp string + message string separately, and include the timestamp string conditionally at render time.
There was a problem hiding this comment.
No need to change Console to support toggling. (mainly because the console is implemented as simply appending raw text to m_pHistory / a CGuiMemo, and I don't want to introduce another copy of the buffer)
| DEFAULT("chat_text_alignment", Chat::Text::Align::LEFT); // chatbox horizontal text alignment | ||
| DEFAULT("server_can_flash_window", true); // allow server to flash the window | ||
| DEFAULT("allow_tray_notifications", true); // allow scripts to create tray balloon notifications | ||
| DEFAULT("show_time_in_chat", false); // show time prefix in chat messages |
There was a problem hiding this comment.
@SpeedyFolf's feedback is valid:
It'd be nice if chat and console were separate options, I'd like to have timestamp shown in console but not chat, I don't want to clutter chat too much but console is a bigger window
|
Maybe also a good idea to add it to the |
|
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically. |
6 participants
Closes #1029
This PR adds timestamp display option for chatbox/console