Skip to content

Commit dbcd447

Browse files
flowerthrowerdenialhaagpre-commit-ci[bot]
authored
Enable ignore by caller inputs (#241)
* enable ignore by caller inputs * ✨ Update CHANGELOG for version 1.18.0 * 🐍 Fix indentation in cpp-linter workflow to calm pre-commit * ✨ Update CHANGELOG for version 1.17.3 * ✨ Updated upgrade guide Signed-off-by: burgholzer <[email protected]> * Apply suggestions from code review Co-authored-by: Daniel Haag <[email protected]> Signed-off-by: Patrick Hopf <[email protected]> * 🎨 pre-commit fixes --------- Signed-off-by: burgholzer <[email protected]> Signed-off-by: Patrick Hopf <[email protected]> Co-authored-by: flowerthrower <[email protected]> Co-authored-by: Daniel Haag <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 1978f4e commit dbcd447

File tree

3 files changed

+33
-2
lines changed

3 files changed

+33
-2
lines changed

.github/workflows/reusable-cpp-linter.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ on:
4646
description: "Packages to install in the Python virtual environment as a comma-separated list"
4747
default: ""
4848
type: string
49+
cpp-linter-ignore-extra:
50+
description: "Extra pipe-separated ignore globs for cpp-linter (e.g., 'plugin/**|subdir/third_party/**')"
51+
default: ""
52+
type: string
4953

5054
jobs:
5155
lint:
@@ -152,7 +156,11 @@ jobs:
152156
style: ""
153157
tidy-checks: ""
154158
version: ${{ inputs.clang-version }}
155-
ignore: "build|!build/mlir/**|**/include|include"
159+
ignore: ${{ format(
160+
'build|!build/mlir/**|**/include|include{0}{1}',
161+
inputs.cpp-linter-ignore-extra != '' && '|' || '',
162+
inputs.cpp-linter-ignore-extra
163+
) }}
156164
thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
157165
step-summary: true
158166
database: "build"

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ This project adheres to [Semantic Versioning], with the exception that minor rel
1111

1212
## [1.17.3] - 2025-11-26
1313

14+
_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#1173)._
15+
16+
### Added
17+
18+
- ✨ Add optional `cpp-linter-ignore-extra` input to allow ignoring additional files in C++ linter ([#241]) ([**@flowerthrower**])
19+
1420
### Fixed
1521

1622
- 🐍🚨 Ensure a locked version of `ty` is used when enabled to guarantee stability ([#255]) ([**@burgholzer**])
@@ -192,6 +198,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._
192198
[#255]: https://github.com/munich-quantum-toolkit/workflows/pull/255
193199
[#254]: https://github.com/munich-quantum-toolkit/workflows/pull/254
194200
[#247]: https://github.com/munich-quantum-toolkit/workflows/pull/247
201+
[#241]: https://github.com/munich-quantum-toolkit/workflows/pull/241
195202
[#206]: https://github.com/munich-quantum-toolkit/workflows/pull/206
196203
[#188]: https://github.com/munich-quantum-toolkit/workflows/pull/188
197204
[#184]: https://github.com/munich-quantum-toolkit/workflows/pull/184
@@ -215,6 +222,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._
215222
[**@burgholzer**]: https://github.com/burgholzer
216223
[**@ystade**]: https://github.com/ystade
217224
[**@denialhaag**]: https://github.com/denialhaag
225+
[**@flowerthrower**]: https://github.com/flowerthrower
218226

219227
<!-- General links -->
220228

UPGRADING.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,25 @@ This document describes breaking changes and how to upgrade. For a complete list
66

77
## [1.17.3]
88

9+
### Type checking with `ty`
10+
911
This release fixes the `ty` linter workflow, which would always use the latest version of `ty` available on PyPI.
1012
As `ty` is still moving pretty fast and the latest version may not be stable yet, this was not ideal.
1113
This release changes the behavior to use the version of `ty` listed as a development dependency in `pyproject.toml`.
1214
If you have the `enable-ty` option set to `true` in your workflow configuration, you **must** add `ty` to your development dependencies or the workflow will fail.
1315

16+
### Additional customization for the C++ linter
17+
18+
This release adds the optional `cpp-linter-ignore-extra` input to the `reusable-cpp-linter.yml` workflow.
19+
This allows ignoring additional files in the C++ linter workflow by passing a pipe-separated list of globs.
20+
For example, to ignore all files in the `plugin` directory and the `subdir/third_party` directory, you can use the following configuration:
21+
22+
```yaml
23+
uses: munich-quantum-toolkit/workflows/.github/workflows/[email protected]
24+
with:
25+
cpp-linter-ignore-extra: "plugin/**|subdir/third_party/**"
26+
```
27+
1428
## [1.17.0]
1529
1630
This release removes all CodeQL workflows because CodeQL is now run automatically by GitHub.
@@ -166,7 +180,8 @@ Consider removing any `-G Ninja` flags from your CMake invocations under Windows
166180

167181
<!-- Version links -->
168182

169-
[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...HEAD
183+
[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD
184+
[1.17.3]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...v1.17.3
170185
[1.17.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.16.0...v1.17.0
171186
[1.16.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.15.0...v1.16.0
172187
[1.15.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.14.0...v1.15.0

0 commit comments

Comments
 (0)